Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nix Rust overlay breaks Linux builds (CI) #1088

Open
0xmovses opened this issue Mar 7, 2025 · 3 comments
Open

Nix Rust overlay breaks Linux builds (CI) #1088

0xmovses opened this issue Mar 7, 2025 · 3 comments
Assignees
Labels
Priority: High After critical issues are fixed, these should be dealt with before any further issues.

Comments

@0xmovses
Copy link
Contributor

0xmovses commented Mar 7, 2025

This change causes the nix build to break on some Linux drivers, it caused problems @musitdev locally and it would cause the same issues in CI.

We can revert to the previous Hash. But was the version bumped for a good reason before? @l-monninger

Image

@l-monninger
Copy link
Collaborator

This was bumped to address issues related to diesel. You can try to revert it.

@0xmovses
Copy link
Contributor Author

0xmovses commented Mar 7, 2025

I'm concerned that if we do so, it will bring back these diesel issues. Will try in a PR.
cc @musitdev

@0xmovses 0xmovses self-assigned this Mar 7, 2025
@0xmovses 0xmovses added the Priority: High After critical issues are fixed, these should be dealt with before any further issues. label Mar 7, 2025
@musitdev
Copy link
Contributor

musitdev commented Mar 7, 2025

I've reverted and it builds. So we don't need to update Rustc for now, but it's going to be very hard to be able to build with the crate dep that update version without respecting semver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High After critical issues are fixed, these should be dealt with before any further issues.
Projects
None yet
Development

No branches or pull requests

3 participants