Mock Tokens Initial Scope #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Primata
requested review from
l-monninger,
andyjsbell,
0xmovses and
mzabaluev
as code owners
0xmovses
requested changes
Jul 16, 2024
protocol-units/mock-assets/devnet/m1/mevm/src/interfaces/IWETH10.sol
Outdated
Show resolved
Hide resolved
protocol-units/mock-assets/devnet/m2/sui/tests/mock_tokens_tests.move
Outdated
Show resolved
Hide resolved
l-monninger
requested changes
Jul 18, 2024
protocol-units/mock-assets/devnet/m1/mevm/.github/workflows/test.yml
Outdated
Show resolved
Hide resolved
protocol-units/mock-assets/testnet/suzuka/aptos/sources/faucet.move
Outdated
Show resolved
Hide resolved
protocol-units/mock-assets/testnet/suzuka/aptos/sources/tokens.move
Outdated
Show resolved
Hide resolved
|
@0xPrimata are you stuck on this? Does it still need to be merged? |
|
What's the status on this? |
l-monninger
approved these changes
Oct 11, 2024
Generally, you should be explaining how they were tested, how someone else should test, and programmatic tests added. |
it's the current devnet and testnet versions, so they are working |
|
Will take one last look over, thanks. |
0xmovses
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
protocol-units,scripts.#203
Scripts and instructions on Mock Tokens deployed on test or development networks.
Changelog
Initializes tokens for:
Testnet
Devnet
Testing
All were throughly tested
Outstanding issues
Deployment