Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(HAL-17) BRIDGE SERVICE STUCK WHILE POLLING SIMULTANEOUS EVENTS #581

Closed
SA124 opened this issue Sep 12, 2024 · 1 comment
Closed

(HAL-17) BRIDGE SERVICE STUCK WHILE POLLING SIMULTANEOUS EVENTS #581

SA124 opened this issue Sep 12, 2024 · 1 comment
Assignees
Labels
bridge Source: Audit Issues discovered by audit.

Comments

@SA124
Copy link

SA124 commented Sep 12, 2024

(HAL-17) BRIDGE SERVICE STUCK WHILE POLLING SIMULTANEOUS EVENTS

Auditor: Halborn
Severity: Medium

Description
The blockchain service's poll_next_event function may enter a deadlock state, returning Pending indefinitely even when events are available for processing, essentially freezing the bridge.

The issue stems from the simultaneous polling of initiator and counterparty events:

Screenshot 2024-09-12 at 11 24 01 AM
Screenshot 2024-09-12 at 11 24 36 AM

BVSS
AO:A/AC:L/AX:L/R:P/S:U/C:N/A:C/I:N/D:C/Y:N (6.3)

Screenshot 2024-09-12 at 11 25 33 AM

Recommendation
It is recommended to handle the case where both events are polled.

@andygolay andygolay added cicd:bridge Source: Audit Issues discovered by audit. labels Sep 13, 2024
@0xmovses
Copy link
Contributor

This logic has been refactored and the issue no longer exists, cc. @musitdev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bridge Source: Audit Issues discovered by audit.
Projects
None yet
Development

No branches or pull requests

3 participants