(HAL-02) USE OF WRONG ERROR MESSAGES

[SA124]

(HAL-02) USE OF WRONG ERROR MESSAGES

Auditor: Halborn
Severity: Informational

Description
MCR SENDS WRONG ERROR MESSAGE ON BLOCK ALREADY COMMITED
In the MCR.sol contract, the error message returned when the proposed block commitment height is behind the tolerable block height is AttesterAlreadyCommitted which can be confusing, as it is not describing the issue and is also used for when the attester tries to submit the same block commitment twice.

Recommendation
It is recommended to:

Replace the MCR error message by a more understandable message such as BlockCommitmentTooFarAhead.
Replace the Bridge error message by a more understandable message such as TimeLockNotExpired.

[0xmovses]

Fixed in #693