Gas Upgrades and Beta Fixes #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide From conversion impls to construct PrivateKey and Signature from byte arrays. The conversions into PrivateKey are fallible, while a Signature is allowed to be constructed from any 64 bytes.
Add TestSigner providing an in-process Signing implementation for tests.
TryFromBytes is not needed, neither is the public key as a member of HashiCorpVault state.
…yz/movement into musitdev/alloy-integration
…github.com/movementlabsxyz/movement into l-monninger/secure-signing-e2e-integration
l-monninger
requested review from
0xmovses,
mzabaluev and
musitdev
as code owners
l-monninger
changed the base branch from
main
to
l-monninger/secure-signing-e2e-integration
musitdev
approved these changes
Feb 16, 2025
There was a problem hiding this comment.
Thanks for doing it. I've planned to work on it this weekend, so I was able to work on other things.
I've done the bring-up elsa-to-biarritz-rc1 upgrade locally using local keys and it works.
I have this message during the migration:
2025-02-16T09:44:03.888562Z INFO maptos_framework_release_util: release proposal transaction failed, but we will still attempt to vote through: Proposing("submitting transaction failed with: Unknown(Transaction committed on chain, but failed execution: MiscellaneousError(Some(CONSTRAINT_NOT_SATISFIED)))")
2025-02-16T09:44:07.679691Z INFO maptos_framework_release_util: release proposal transaction failed, but we will still attempt to vote through: Proposing("submitting transaction failed with: Unknown(Transaction committed on chain, but failed execution: MiscellaneousError(Some(CONSTRAINT_NOT_SATISFIED)))")
I have 2 questions:
- This migration process is only for existing node that was started before the update. If I start a node from this rev commit, do I have to do it?
- now in the
bring-up elsa-to-biarritz-rc1 upgradeyou've to pass the key string<MAPTOS_SIGNER> <DA_SIGNER> <MCR_SIGNER>. Can we change the keys from the current config because for the existing nodes we've to migrate from local keys to vault keys or there's something else to do before.
musitdev
approved these changes
Feb 16, 2025
|
There's some issue to build everything. The |
…com/movementlabsxyz/movement into l-monninger/gas-upgrades-beta-fixes
…on incompatibilities
|
The build works now. There's still an issue with Helios container push. |
musitdev
changed the base branch from
l-monninger/secure-signing-e2e-integration
to
main
musitdev
changed the base branch from
main
to
l-monninger/secure-signing-e2e-integration
musitdev
changed the base branch from
l-monninger/secure-signing-e2e-integration
to
main
radupopa369
approved these changes
Feb 19, 2025
musitdev
approved these changes
Feb 19, 2025
mcmillennick
pushed a commit
that referenced
this pull request
Mar 9, 2025
Co-authored-by: Andy Golay <andygolay@gmail.com> Co-authored-by: musitdev <philippe.delrieu@free.fr> Co-authored-by: Mikhail Zabaluev <mikhail.zabaluev@movementlabs.xyz> Co-authored-by: Richard Melkonian <35300528+0xmovses@users.noreply.github.com> Co-authored-by: Icarus131 <anirudhprasad131@protonmail.com> Co-authored-by: primata <primata@movementlabs.xyz> Co-authored-by: Icarus131 <anirudhprasad131@gmail.com> Co-authored-by: Richard Melkonian <r.v.melkonian@gmail.com> Co-authored-by: Radu Popa <radupopa21be@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
protocol-unitsChangelog
Testing
Test 1: , Start a leader and its follower:
The test execution should have no errors.
Test 2: Do the migration.
In another terminal, do the migration describe in this doc
In the movement repo root, execute this command to do the full upgrade in one command and random keys:
Outstanding issues
I have this message during the migration:
I'm not sure it's important or not.