Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Signing] Update executor block validator signer to use LoadedSigner, add test key admin command #1063

Merged
merged 5 commits into from
Mar 5, 2025

Conversation

musitdev
Copy link
Contributor

@musitdev musitdev commented Feb 19, 2025

Summary

  • RFCs: Link to RFC, Link to RFC, or $\emptyset$.
  • Categories: any of protocol-units, networks, scripts, util, cicd, or misc.

Changelog

  • Update executor block validator signer to use LoadedSigner in initialization bootstrap. The current impl use try_raw_private_key which can only be used with local private key. This code is called during the node startup and prevent from loading HSM keys.
  • Add test key admin command: Add this command to test the string representation of a key and validate that the node can load it. Useful during installation to validate the key is correctly defined.
  • Remove some warnings.

Testing

Outstanding issues

@radupopa369 radupopa369 merged commit d963665 into main Mar 5, 2025
118 of 125 checks passed
mcmillennick pushed a commit that referenced this pull request Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants