Config parameter for celestia light node store directory #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the dead code.
The trait extends tokio's process::Command, allowing flexible construction to take place before running.
Allow the --node.store option to be overridden by config and the default taken from the CELESTIA_LIGHT_NODE_STORE environment variable.
mzabaluev
requested review from
l-monninger,
0xmovses and
musitdev
as code owners
radupopa369
approved these changes
Feb 24, 2025
mzabaluev
merged commit e82cbf6
into
mikhail/celestia-mainnet-config
89 of 109 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a configuration field for the
--node.storeparameter passed to the light node runner.The default is overridable with the
CELESTIA_LIGHT_NODE_STOREenvironment variable.commandergets its ownCommandwrapper to improve ergonomics.