[Node] change block timestamp from sec to microsec #1067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
musitdev
requested review from
l-monninger,
0xmovses and
mzabaluev
as code owners
mzabaluev
reviewed
Feb 26, 2025
…entlabsxyz/movement into musitdev/fix_block_timestamp_error
mzabaluev
approved these changes
Feb 27, 2025
musitdev
changed the base branch from
main
to
l-monninger/gas-upgrades-beta-fixes
…block_timestamp_error
musitdev
merged commit b2b0ad6
into
l-monninger/gas-upgrades-beta-fixes
89 of 93 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
protocol-units,networks,scripts,util,cicd, ormisc.Correct the block timestamp that was defined in sec instead of micro sec.
I use chrono because the function never fails.
Changelog
Testing
Outstanding issues