Gas Upgrades Beta Fixes pt. 2 #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide From conversion impls to construct PrivateKey and Signature from byte arrays. The conversions into PrivateKey are fallible, while a Signature is allowed to be constructed from any 64 bytes.
Add TestSigner providing an in-process Signing implementation for tests.
TryFromBytes is not needed, neither is the public key as a member of HashiCorpVault state.
…yz/movement into musitdev/alloy-integration
…com/movementlabsxyz/movement into l-monninger/gas-upgrades-beta-fixes
…on incompatibilities
…to l-monninger/gas-upgrades-beta-fixes
…com/movementlabsxyz/movement into l-monninger/gas-upgrades-beta-fixes
l-monninger
requested review from
0xmovses,
mzabaluev and
musitdev
as code owners
musitdev
reviewed
Feb 27, 2025
mzabaluev
approved these changes
Feb 27, 2025
Comment on lines
+110
to
+112
| /// Receives a transaction and adds it to the mempool. | ||
| /// todo: it may be wise to move the batching logic up a level to the consuming structs. | ||
| pub(crate) async fn receive_transaction_tick(&mut self) -> Result<(), Error> { |
There was a problem hiding this comment.
Not sure what re-exposing tick under another method name achieves...
radupopa369
approved these changes
Feb 27, 2025
mcmillennick
pushed a commit
that referenced
this pull request
Mar 9, 2025
Co-authored-by: Andy Golay <andygolay@gmail.com> Co-authored-by: musitdev <philippe.delrieu@free.fr> Co-authored-by: Mikhail Zabaluev <mikhail.zabaluev@movementlabs.xyz> Co-authored-by: Richard Melkonian <35300528+0xmovses@users.noreply.github.com> Co-authored-by: Icarus131 <anirudhprasad131@protonmail.com> Co-authored-by: primata <primata@movementlabs.xyz> Co-authored-by: Icarus131 <anirudhprasad131@gmail.com> Co-authored-by: Richard Melkonian <r.v.melkonian@gmail.com> Co-authored-by: Radu Popa <radupopa21be@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
protocol-units,networks,scripts,util,cicd, ormisc.Changelog
Testing
Outstanding issues