Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add back labeled builds #1072

Merged
merged 12 commits into from
Mar 7, 2025
Merged

fix: add back labeled builds #1072

merged 12 commits into from
Mar 7, 2025

Conversation

radupopa369
Copy link
Contributor

@radupopa369 radupopa369 commented Feb 27, 2025

Summary

build containers when a label is applied and not for all commits

Changes

  1. Add back the labeled builds cicd:movement-full-node
  2. Add back labeled builds cicd:bridge
  3. Do not run workflows twice, once for a pull request and once for a git push for every branch.
  4. Increase the runners size

Proposal of optimisation: Trigger workflows only for Pull Requests events

If one opens a PR, one single push commit triggers for 2 events, one for a Pull request and one for a push on a branch.

image

on:
  pull_request:
    types:
      - labeled
      - opened
      - synchronize
  push:
    branches:
      - '**' 

Outstanding issues

build containers when a label is applied and not for all commits

Building only un-checked containers when there are no labels

image

@radupopa369 radupopa369 changed the title feat: add github context content fix: add back labeled builds Mar 6, 2025
@radupopa369 radupopa369 added cicd:bridge cicd:bridge-containers Builds bridge containers. and removed cicd:bridge labels Mar 6, 2025
@radupopa369 radupopa369 marked this pull request as ready for review March 6, 2025 17:54
@radupopa369 radupopa369 merged commit cc6c312 into main Mar 7, 2025
63 of 65 checks passed
@andygolay
Copy link
Contributor

andygolay commented Mar 7, 2025

Awesome, was waiting for resolution of Mikhail's issues to re-review, looks great.

mcmillennick pushed a commit that referenced this pull request Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants