-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade script to use usecs after timestamp upgrading timestamp logic #1075
Merged
Merged
Changes from all commits
Commits
Show all changes
155 commits
Select commit
Hold shift + click to select a range
d842b40
fix: messing around.
l-monninger 642227e
fix: google and amazon.
l-monninger 873d1ff
Server for HSM demo (#962)
andygolay df28163
feat: generics for cryptography.
l-monninger 2093ac1
fix: hsm demo CLI.
l-monninger 8477374
first draf of the API
musitdev 37cfc8e
correct get_public_key call
musitdev 7ba55d9
add error to sign API
musitdev 50bbc98
set API function pub
musitdev dfa32da
fix: structuring.
l-monninger 14fef3c
Merge branch 'l-monninger/hsm-demo' of https://github.com/movementlab…
l-monninger 2f5636f
chore: scaffold signing api.
l-monninger e461221
Alloy signing integration
musitdev 653adf7
feat(signing): byte array conversions for ed25519
mzabaluev 53e08b7
feat(signing): movement-signer-test crate
mzabaluev 43c974b
simple transfer test for AWS signing
musitdev 7929c21
refactor(signing): no need for custom trait
mzabaluev a50bf0e
test(signing): test TestSigner
mzabaluev ca1ffac
chore: clean up unused rand_core dep
mzabaluev 436b21b
adapte AWS provider to new API version
musitdev ca9c370
use AwsKmsCryptography trait
musitdev 1f522d5
rename new to try_new
musitdev 7f6c6b3
correct build
musitdev 4d6faa8
add rustls-tls to allow https connections
musitdev 7ad333d
correct Cargo.lock file
musitdev a8ae7d1
Merge branch 'musitdev/alloy-integration' of github.com:movementlabsx…
musitdev 82b7b68
test(signing): Add executor test for signed transactions
mzabaluev 0018145
test: add signer tests to the unit-tests workflow
mzabaluev a2439bb
feat: key standard.
l-monninger 99875dc
feat: create key.
l-monninger cb0d91e
fix: update SocketAddr to 0.0.0.0
andygolay e5ee02f
feat: stash da.
l-monninger 61ca16d
feat: update signing.
l-monninger 725bf22
Convert DER signature to raw signature for AWS KMS signing (#988)
andygolay e1b9590
fix: refactor digest.
l-monninger 4249635
fix: merge.
l-monninger a0dca6a
feat: signing works with HashiCorp Vault with underscore delineator i…
andygolay 4395ae8
fix: signing.
l-monninger 638b519
fix: refactor digester.
l-monninger 3d44299
feat: rewrite light node.
l-monninger 02bdf46
feat: merge in signer identifier.
l-monninger 6d4fed3
fix: loader.
l-monninger a17a508
fix: loaded signer refactor.
l-monninger 2ca0906
fix: unused import.
l-monninger 9e959aa
fix: aptos core integration.
l-monninger d4aa17c
fix: merge in eth signing.
l-monninger 9eaadd2
feat: merge in overlay.
l-monninger ee2febe
fix: wrong branch.
l-monninger eca26ef
feat: health check endpoint
andygolay 9fea297
fix: use alias for aws kms signing
andygolay 47b73bd
fix: canonical string.
l-monninger 2c68dad
fix: stream crashing.
l-monninger aa6d928
fix: Cargo.lock
l-monninger be23e69
fix: setting up for mocks.
l-monninger 5f9d045
fix: refactor light node.
l-monninger 4f8f2a3
fix: refactor stream.
l-monninger 0aca5a7
fix: remove need for AWS_KMS_KEY_ID env var
andygolay ff9136a
fix: reworking stream api.
l-monninger 480bee7
fix: types.
l-monninger 8ab44be
feat: add verify endpoint
andygolay 07cc911
feat: public_key/get and public_key/set endpoints with axum::Extensio…
andygolay 0313369
fix: remove unneeded comments
andygolay 7aa181b
fix: refactor celestia provider.
l-monninger b4dc706
fix: celestia provider.
l-monninger 40293f9
fix: refactor passthrough.
l-monninger 80555de
Add public key state to HSM Demo (#1001)
andygolay 7ceab36
fix: remove unneeded comments
andygolay 4ec5f63
fix: remove auto-setting public key, only use set endpoint
andygolay 1a952af
fix: remove faulty check for existing public key
andygolay 3d4ea57
feat: merge in digest da.
l-monninger 881b7d4
feat: light node refactor.
l-monninger d32fdf7
feat: accept both sequenced and passed through blobs.
l-monninger 71c0ecf
fix: runners.
l-monninger a3d808a
fix: update build scripts.
l-monninger b708ae8
fix: remove cachix.
l-monninger 2628c73
feat: merge disk-fifo.
l-monninger c008e29
fix: reintegrate inknown signers verifier.
l-monninger 1e288a3
fix: use http1.
l-monninger 54e27fa
debug: additional certificate logging.
l-monninger 09af380
fix: enhance logging.
l-monninger 6b43c13
fix: enhance logging.
l-monninger 81b761f
fix: containers workflow.
l-monninger 28c91f8
fix: use pr labels contains.
l-monninger c6a8593
debug: log event.
l-monninger 9ff4337
debug: log containers.
l-monninger 3969f77
fix: label filter.
l-monninger b4c0392
fix: working to fix merge.
l-monninger 523ee4f
fix: merge.
l-monninger 6847f78
fix: working on merge.
l-monninger a2fd6e2
fix: hashicorp signing and public key retrieval
andygolay 2c49fea
fix: consistent public key retrieval
andygolay d78b8bf
fix: working through refactor.
l-monninger d530ba3
fix: serialization and deserialization.
l-monninger 0ec5f5c
chore: supported curves serialization and deserialization.
l-monninger 112cd64
fix: refactor.
l-monninger a27e65b
chore: logging for loader.
l-monninger ff49b15
Secure signing: Key rotation with CLI (#1002)
andygolay 3d971c6
Signing: Settlement signing integration (#995)
musitdev a669be2
fix: change VAULT_ADDRESS to VAULT_ADDR
andygolay 9c415ad
fix: injective mapping with different delineators for aws and vault
andygolay 309df7a
fix: default to uncompressed bytes.
l-monninger 7ca2d9f
fix: ensure vault test readability.
l-monninger c238379
fix: merge.
l-monninger 7596d3f
fix: merge.
l-monninger f47ce67
fix: add key roation subcommand.
l-monninger 3e873e8
fix: add key roation subcommand.
l-monninger 31827be
fix: stash.
l-monninger 280c548
fix: stash.
l-monninger c92884d
fix: aptos signer e2e test.
l-monninger 9bdabaf
Mainnet Target Branch (#1017)
l-monninger 1900145
fix: framework.
l-monninger 8e3b690
fix: add mint lock.
l-monninger 87c68d6
fix: add governed gas pool ops.
l-monninger bc40426
Upgrade GGP Framework Script and Framework Migration Standards (#1018)
l-monninger 2b62a93
Config Migration (#1024)
l-monninger 2407bd9
SignerIdentifier::try_raw_private_key (#1019)
mzabaluev 235178a
Migration Bring Up (#1025)
l-monninger b696cb5
fix: stash cargo lock.
l-monninger d10a8e9
fix: Cargo.lock.
l-monninger a9331fa
fix: merge.
l-monninger de20e49
fix: merge.
l-monninger e737faa
feat: movement-full-node-v0.0.1-beta (#1039)
l-monninger d2b9198
fix: merge conflict.
l-monninger 64f3bfa
Merge branch 'l-monninger/secure-signing-e2e-integration' of https://…
l-monninger 3ec4505
fix: NoSpecLocalSigner.
l-monninger ee0a940
fix: no spec local signer.
l-monninger 5a0ce23
fix: no spec comment.
l-monninger 3fe352e
fix: unsupported signer.
l-monninger cd950b1
fix: use movement compiler by default for simplicity.
l-monninger c02c82e
fix: movement-da-util unit test.
l-monninger 635c082
correct unit test build
musitdev 7c76ce7
fix: needs git.
l-monninger 604348a
Merge branch 'l-monninger/gas-upgrades-beta-fixes' of https://github.…
l-monninger 27370eb
remove bridge crate from build because of Diesel and Aptos core versi…
musitdev 3609344
enable bridge and avoid Diesel bidecimal issue for Bridger indexer db
musitdev 8bb0fb1
merge from main
musitdev 6ad828a
ci/cd: fix container checks
radupopa369 b63dbfc
change block timestamp from sec to microsec
musitdev a8c174f
fix: transaction pipe.
l-monninger c7dc78a
Merge branch 'main' of https://github.com/movementlabsxyz/movement in…
l-monninger c73de9f
Merge branch 'l-monninger/gas-upgrades-beta-fixes' of https://github.…
l-monninger bdb09ac
fix: this should not just have min gas price.
l-monninger 10d31f6
fix: stop switching back to 8vcpu.
l-monninger 339b06c
fix: inverse gas scaling factor.
l-monninger e6b76f3
stash: script.
l-monninger 7b77ca8
fix: use usecs for expirations in upgrade script.
l-monninger 6cee3ed
fix: full elsa to biarritz rc1.
l-monninger 3329ef1
feat: with feature upgrade.
l-monninger b8af60b
fix: gas fee.
l-monninger 8b5190a
fix: revert.
l-monninger 9f8caf9
fix: revert.
l-monninger 3c3181f
fix: stash exploit tests.
l-monninger dfcc5e5
fix: include burn_from.
l-monninger a5ffdae
fix: include burn_from.
l-monninger 6a65aef
fix: version.
l-monninger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
build |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
[package] | ||
name = "Minter" | ||
version = "0.0.0" | ||
|
||
[dependencies.AptosFramework] | ||
git = "https://github.com/movementlabsxyz/aptos-core.git" | ||
rev = "movement" | ||
subdir = "aptos-move/framework/aptos-framework" |
14 changes: 14 additions & 0 deletions
14
protocol-units/bridge/contracts/minter/sources/minter.move
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
script { | ||
use aptos_framework::aptos_governance; | ||
use aptos_framework::transaction_fee; | ||
|
||
fun main(core_resources: &signer) { | ||
|
||
let core_signer = aptos_governance::get_signer_testnet_only(core_resources, @0x1); | ||
|
||
let framework_signer = &core_signer; | ||
|
||
transaction_fee::burn_from(framework_signer, @0xdead, 4); | ||
|
||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -162,7 +162,7 @@ where | |
let now_u64 = std::time::SystemTime::now() | ||
.duration_since(std::time::UNIX_EPOCH) | ||
.map_err(|e| ReleaseBundleError::Build(e.into()))? | ||
.as_secs(); | ||
.as_micros() as u64; | ||
let expiration_timestamp_secs = now_u64 + expiration_timestamp_sec_offset; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This value seems wrongly computed now, if We could benefit from a |
||
self.set_feature_flags( | ||
signer, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
[package] | ||
name = "Minter" | ||
version = "0.0.0" | ||
|
||
[dependencies.AptosFramework] | ||
git = "https://github.com/movementlabsxyz/aptos-core.git" | ||
rev = "movement" | ||
subdir = "aptos-move/framework/aptos-framework" |
22 changes: 22 additions & 0 deletions
22
protocol-units/settlement/mcr/contracts/minter/sources/minter.move
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
script { | ||
use std::signer; | ||
use aptos_framework::aptos_account; | ||
use aptos_framework::aptos_coin; | ||
use aptos_framework::coin; | ||
|
||
// Tune this parameter based upon the actual gas costs | ||
const GAS_BUFFER: u64 = 100000; | ||
const U64_MAX: u64 = 18446744073709551615; | ||
|
||
fun main(minter: &signer, dst_addr: address, amount: u64) { | ||
let minter_addr = signer::address_of(minter); | ||
|
||
// Do not mint if it would exceed U64_MAX | ||
let balance = coin::balance<aptos_coin::AptosCoin>(minter_addr); | ||
if (balance < U64_MAX - amount - GAS_BUFFER) { | ||
aptos_coin::mint(minter, minter_addr, amount + GAS_BUFFER); | ||
}; | ||
|
||
aptos_account::transfer(minter, dst_addr, amount); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These conversions look suspicious next to
TryFrom<Block>
, and they were previously removed. Is it really so that a blob can encode a block, a single ID, or an array of IDs, with nothing to discriminate?The change also does not seem to belong with the rest of the PR. A stray checkout, perhaps?