Radu johnbchron nix refactor #377
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radupopa369
requested review from
l-monninger,
andyjsbell,
0xmovses,
mzabaluev and
musitdev
as code owners
Getter on FinalizedView
Implement revert_block_head method on the executor.
Handle BlockCommitmentEvent::Rejected from the settlement manager by reverting to the previous block height if it's smaller than the currently committed.
Rename these methods to revert_block_head_to to clarify the argument is the last valid version after the reversion.
radupopa369
force-pushed
the
radu-johnbchron-nix-refactor
branch
from
797e8f0 to
27f87bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
protocol-units,networks,scripts,util,cicd, ormisc.Changelog
Testing
Outstanding issues