Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

High Sequence Number Gas DOS #597

Closed
wants to merge 21 commits into from
Closed

High Sequence Number Gas DOS #597

wants to merge 21 commits into from

Conversation

l-monninger
Copy link
Collaborator

@l-monninger l-monninger commented Sep 13, 2024 •
edited
Loading

Summary

  • RFCs: $\emptyset$.
  • Categories: any of protocol-units

Resolves #490 DoS attack by simply checking by two non-exclusive methods:

  1. Prohibits high sequence numbers and prevents redundant sequence numbers from entering the mempool on a single node in High Sequence Number Elimination and No Redundant Sequence Number by Node #661. This effectively means that attacks can only run TOO_NEW_TOLERANCE transactions.
  2. Charges base gas fees for validation only transactions in Validation Gas Fees #665, i.e., transactions that fail after validation still incur the base gas fee. Validation Gas Fees #665 has been excluded until further verification.

Testing

  1. Adds e2e test to match No gas fees for high sequence number transactions allows resource abuse #490 attack scripts. These are grouped under cicd:suzuka-full-node-malicious.
  2. Adds unit tests to TransactionPipe.

Outstanding issues

None

@l-monninger l-monninger marked this pull request as ready for review September 13, 2024 10:56
@l-monninger l-monninger mentioned this pull request Sep 13, 2024
Merged
mzabaluev
mzabaluev reviewed Oct 7, 2024
View reviewed changes
@l-monninger l-monninger mentioned this pull request Oct 7, 2024
Merged
l-monninger and others added 2 commits October 8, 2024 13:00
@l-monninger
fix: mempool timeout.
20e7a29
@l-monninger
Merge pull request #661 from movementlabsxyz/l-monninger/high-sequenc…
73b82af 
…e-number-dos-no-redundant-seq-numbers

High Sequence Number Elimination and No Redundant Sequence Number by Node
@l-monninger l-monninger added cicd:suzuka-full-node-malicious Malicious tests against Suzuka Full Node logic. and removed cicd:suzuka-full-node-malicious Malicious tests against Suzuka Full Node logic. labels Oct 18, 2024
l-monninger and others added 4 commits October 21, 2024 14:26
@l-monninger @mzabaluev
Update protocol-units/execution/opt-executor/src/gc_account_sequence_…
f4f2fdf 
…number.rs

Co-authored-by: Mikhail Zabaluev <mikhail.zabaluev@movementlabs.xyz>
@l-monninger @mzabaluev
Update protocol-units/execution/opt-executor/src/gc_account_sequence_…
0be4fb4 
…number.rs

Co-authored-by: Mikhail Zabaluev <mikhail.zabaluev@movementlabs.xyz>
@l-monninger @mzabaluev
Update protocol-units/execution/opt-executor/src/gc_account_sequence_…
2ff0b41 
…number.rs

Co-authored-by: Mikhail Zabaluev <mikhail.zabaluev@movementlabs.xyz>
@l-monninger @mzabaluev
fix: accept merge.
6bbe370
@mzabaluev mzabaluev force-pushed the l-monninger/high-sequence-number-dos branch from 2c35893 to 6bbe370 Compare October 21, 2024 11:28
This was referenced Oct 21, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzabaluev mzabaluev mzabaluev approved these changes

@andyjsbell andyjsbell Awaiting requested review from andyjsbell

@0xmovses 0xmovses Awaiting requested review from 0xmovses 0xmovses is a code owner

Assignees
No one assigned
Labels
cicd:suzuka-full-node-malicious Malicious tests against Suzuka Full Node logic.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No gas fees for high sequence number transactions allows resource abuse
2 participants
@l-monninger @mzabaluev