Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralized Signed Blobs #604

Closed
wants to merge 18 commits into from

Conversation

l-monninger
Copy link
Collaborator

@l-monninger l-monninger commented Sep 17, 2024

Summary

Implements trusted-only blob reading and writing with the following:

  • Signs blocks sent to DA.
  • Checks signature on block was made by well-known signers.
  • Moves compression and decompression of blobs for Celestia down into DA.

Testing

  1. e2e tests confirm Suzuka Behavior is unchanged.
  2. Unit tests for formatting and basic verification included.

Outstanding issues

  1. Lots of potential for unit tests here.
  2. Though this is using secp256k1, the key serialization and deserialization format is not yet compatible with ETH hex encoding: Permissioned Signers Private and Public Key Format Should Match ETH #710
  3. There should probably be an e2e test for a malicious signer that is ignored: Include e2e tests covering malicious signer to ensure permissioned signer controls are always checked #711

l-monninger and others added 2 commits September 17, 2024 11:58
Co-authored-by: Mikhail Zabaluev <mikhail.zabaluev@movementlabs.xyz>
@l-monninger l-monninger marked this pull request as ready for review September 30, 2024 15:02
Copy link
Contributor

@Primata Primata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if I could be of much help to evaluate code.

This was referenced Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants