Validation Gas Fees #665
Closed
Validation Gas Fees #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l-monninger
requested review from
andyjsbell,
0xmovses and
mzabaluev
as code owners
l-monninger
changed the base branch from
main
to
l-monninger/high-sequence-number-dos
Primata
reviewed
Oct 9, 2024
| @@ -260,6 +265,24 @@ mod tests { | |||
| SignedTransaction::new(raw_transaction, public_key, Ed25519Signature::dummy_signature()) | |||
| } | |||
|
|
|||
| fn create_signed_transaction_for_account( | |||
There was a problem hiding this comment.
This seems like the only significant chunk of code that should be performing validation, but I'm not exactly seeing gas fees for validation 🤔
There was a problem hiding this comment.
It's in Aptos Core. What you're looking at is a test.
andyjsbell
approved these changes
Oct 18, 2024
| // Initialize a root account using a predefined keypair and the test root address. | ||
| let root_account = LocalAccount::new( | ||
| aptos_test_root_address(), | ||
| AccountKey::from_private_key(context.config().chain.maptos_private_key.clone()), |
There was a problem hiding this comment.
We may want to fix this smelly one at some point in a new PR
|
Marking this as draft for reasons discussed internally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
protocol-unitsIntegrates
validation_onlygas fee intomaptos_opt_executorand adds tests.Testing
Outstanding issues