Centralized Blobs #716
Centralized Blobs #716
Conversation
l-monninger
requested review from
andyjsbell,
0xmovses and
mzabaluev
as code owners
| @@ -102,6 +101,7 @@ godfig = { path = "util/godfig" } | |||
| movement-tracing = { path = "util/tracing" } | |||
| syncup = { path = "protocol-units/syncing/syncup" } | |||
| syncador = { path = "util/syncador" } | |||
| bridge-grpc = { path = "protocol-units/bridge/grpc" } | |||
There was a problem hiding this comment.
The old place was better grouped with the other protocol-units/bridge crates.
| @@ -102,6 +101,7 @@ godfig = { path = "util/godfig" } | |||
| movement-tracing = { path = "util/tracing" } | |||
| syncup = { path = "protocol-units/syncing/syncup" } | |||
There was a problem hiding this comment.
Then again, there's this one out of place as well.
| } | ||
|
|
||
| mod block { | ||
| pub mod block { |
There was a problem hiding this comment.
Forgot about this one. It could be moved to a separate file as well, especially now that it's a public module (in its super module at least).
| } | ||
|
|
||
| #[cfg(test)] | ||
| pub mod signers_serialization_test { |
There was a problem hiding this comment.
Why is this module public?
| use super::*; | ||
|
|
||
| #[test] | ||
| fn test_signing_key() -> Result<(), anyhow::Error> { |
There was a problem hiding this comment.
This only tests the byte format of the signing key, why do we need the test for dependency functionality?
| } | ||
| } | ||
|
|
||
| #[derive(Debug, Clone, Serialize, Deserialize)] |
There was a problem hiding this comment.
How do Serialize and Deserialize represent the enum? Should we add some attributes there?
| } | ||
|
|
||
| #[derive(Debug, Clone, Serialize, Deserialize)] | ||
| pub struct InnerSignedBlobV1 { |
There was a problem hiding this comment.
The Inner naming still pops up here.
| } | ||
| } | ||
|
|
||
| pub mod celestia { |
There was a problem hiding this comment.
Could be in a separate file.
| fn gc_mempool_transactions( | ||
| &self, | ||
| timestamp_threshold: u64, | ||
| ) -> impl Future<Output = Result<u64, anyhow::Error>> + Send + '_; | ||
| ) -> impl Future<Output = Result<(), anyhow::Error>> + Send + '_; |
There was a problem hiding this comment.
Why erase the logging we have just added in #709?
| fn gc_mempool_transactions( | ||
| &self, | ||
| timestamp_threshold: u64, | ||
| ) -> impl Future<Output = Result<u64, anyhow::Error>> + Send + '_; | ||
| ) -> impl Future<Output = Result<(), anyhow::Error>> + Send + '_; |
There was a problem hiding this comment.
Why erase the logging we have just added in #709?
Summary
protocol-units#604 , but signed.