Skip to content

heartbeat hangs instead of failing #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
glasserc opened this issue Sep 24, 2018 · 1 comment
Closed

heartbeat hangs instead of failing #59

glasserc opened this issue Sep 24, 2018 · 1 comment
Assignees
@pjenvey

Comments

@glasserc
Copy link

On my machine, the __heartbeat__ endpoint works fine when the database is up, but when I shut it down, the same endpoint just hangs, with megaphone dumping errors to console like Error: Can't connect to MySQL server on 'golden-cloud.local' (111). After about 30 seconds, I get an error response like this:

*   Trying ::1...
* TCP_NODELAY set
* Connected to localhost (::1) port 8000 (#0)
> GET /__heartbeat__ HTTP/1.1
> Host: localhost:8000
> User-Agent: curl/7.61.0
> Accept: */*
> 
< HTTP/1.1 503 Service Unavailable
< Content-Type: text/html; charset=utf-8
< Server: Rocket
< Content-Length: 510
< Date: Mon, 24 Sep 2018 23:10:22 GMT
< 

            <!DOCTYPE html>
            <html>
            <head>
                <meta charset="utf-8">
                <title>503 Service Unavailable</title>
            </head>
            <body align="center">
                <div align="center">
                    <h1>503: Service Unavailable</h1>
                    <p>The server is currently unavailable.</p>
                    <hr />
                    <small>Rocket</small>
                </div>
            </body>
            </html>
* Connection #0 to host localhost left intact

Technically, I guess this is correct -- the 503 indicates that the heartbeat has failed -- but based on the structure of the JSON response, I assumed that it was possible for a response to have status be ok but database be error.
@glasserc glasserc mentioned this issue Sep 24, 2018
Merged
@pjenvey
Copy link
Member

pjenvey commented Oct 8, 2018 •
edited
Loading

Most db errors render a JSON response, but this one's a failure to checkout a db conn from the pool. Due to our web framework (Rocket) this is done in a rocket request guard which currently lacks an easy way to customize error responses.

It can be worked around though.

pjenvey added a commit that referenced this issue Oct 8, 2018
@pjenvey
fix: propagate db pool errors into HandlerErrors
6f8de75 
and properly render their error responses

Closes #59
@pjenvey pjenvey self-assigned this Oct 8, 2018
pjenvey added a commit that referenced this issue Oct 9, 2018
@pjenvey
fix: propagate db pool errors into HandlerErrors
d5abfa5 
and properly render their error responses (special casing heartbeat's
handling)

Closes #59
pjenvey added a commit that referenced this issue Oct 9, 2018
@pjenvey
fix: propagate db pool errors into HandlerErrors
c9300c0 
and properly render their error responses (special casing heartbeat's
handling)

also add cargo fmt -- --check

Closes #59
@pjenvey pjenvey mentioned this issue Oct 9, 2018
Merged
pjenvey added a commit that referenced this issue Oct 9, 2018
@pjenvey
fix: propagate db pool errors into HandlerErrors
3156643 
and properly render their error responses (special casing heartbeat's
handling)

Closes #59
pjenvey added a commit that referenced this issue Oct 31, 2018
@pjenvey
feat: improve the README
b56fbe4 
Closes #59
pjenvey added a commit that referenced this issue Oct 31, 2018
@pjenvey
feat: improve the README
c3a0cf1 
Closes #59
pjenvey added a commit that referenced this issue Oct 31, 2018
@pjenvey
feat: improve the README
e94cc34 
Closes #59
pjenvey added a commit that referenced this issue Oct 31, 2018
@pjenvey
feat: improve the README
742d75c 
Closes #59
pjenvey added a commit that referenced this issue Oct 31, 2018
@pjenvey
feat: improve the README
92371bd 
Closes #59
@pjenvey pjenvey mentioned this issue Oct 31, 2018
Merged
pjenvey added a commit that referenced this issue Nov 1, 2018
@pjenvey
feat: improve the README
e1aa507 
Closes #59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pjenvey pjenvey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pjenvey @glasserc @bbangert