Skip to content

Commit 5f4acd2

Browse files
authored
feat(nimbus): add custom targeting for users with large screen devices (#12645)
Because it's required to target users with large screen devices This commit adds the custom targeting keys for experimenter Fixes #12644
1 parent 64ed59c commit 5f4acd2

File tree

2 files changed

+13
-0
lines changed

2 files changed

+13
-0
lines changed

experimenter/experimenter/targeting/constants.py

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2092,6 +2092,18 @@ def __post_init__(self):
20922092
application_choice_names=(Application.FENIX.name,),
20932093
)
20942094

2095+
2096+
ANDROID_LARGE_SCREEN_USERS_ONLY = NimbusTargetingConfig(
2097+
name="Large screen device users only",
2098+
slug="large_screen_device_users_only",
2099+
description="Targeting users who have large screen devices",
2100+
targeting="is_large_device",
2101+
desktop_telemetry="",
2102+
sticky_required=False,
2103+
is_first_run_required=False,
2104+
application_choice_names=(Application.FENIX.name,),
2105+
)
2106+
20952107
DEFAULT_PDF_IS_DIFFERENT_BROWSER = NimbusTargetingConfig(
20962108
name="Default PDF handler is a different browser",
20972109
slug="default_pdf_is_different_browser",

experimenter/tests/integration/nimbus/test_mobile_targeting.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,7 @@ def test_check_mobile_targeting(
103103
"has_enabled_tips_notifications": True,
104104
"install_referrer_response_utm_source": "test",
105105
"number_of_app_launches": 1,
106+
"is_large_device": True,
106107
}
107108
)
108109
client = sdk_client(load_app_context(context))

0 commit comments

Comments
 (0)