Skip to content

Commit 9877724

Browse files
chore(nimbus): set use_group_id to true for clones (#12588)
Becuase * We recently changed the default randomization unit on desktop to group_id * Clones of experiments before that change will still fall back to normandy_id * We need to force clones to switch to group_id This commit * Forces use_group_id to true for cloned experiments fixes #12558
1 parent f8b7d9f commit 9877724

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

experimenter/experimenter/experiments/models.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1489,6 +1489,7 @@ def clone(self, name, user, rollout_branch_slug=None, changed_on=None):
14891489
cloned.takeaways_metric_gain = False
14901490
cloned.takeaways_gain_amount = None
14911491
cloned.takeaways_qbr_learning = False
1492+
cloned.use_group_id = True
14921493
cloned._start_date = None
14931494
cloned._end_date = None
14941495
cloned._enrollment_end_date = None

experimenter/experimenter/experiments/tests/test_models.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3011,6 +3011,7 @@ def test_clone_dirty_rollout(self):
30113011
NimbusExperimentFactory.Lifecycles.LIVE_DIRTY,
30123012
is_rollout=True,
30133013
is_rollout_dirty=True,
3014+
use_group_id=False,
30143015
)
30153016
rollout_branch = parent.branches.first()
30163017
child = self._clone_experiment_and_assert_common_expectations(
@@ -3043,6 +3044,7 @@ def _clone_experiment_and_assert_common_expectations(
30433044
self.assertEqual(child.takeaways_metric_gain, False)
30443045
self.assertEqual(child.takeaways_qbr_learning, False)
30453046
self.assertEqual(child.takeaways_summary, None)
3047+
self.assertEqual(child.use_group_id, True)
30463048
self.assertEqual(child.conclusion_recommendations, [])
30473049
self.assertEqual(child.qa_status, NimbusExperiment.QAStatus.NOT_SET)
30483050
self.assertEqual(child.qa_comment, None)

0 commit comments

Comments
 (0)