Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hidden questions are shown while waiting for API results #166

Closed
WesleyBranton opened this issue Sep 24, 2020 · 0 comments · Fixed by #169
Closed

Hidden questions are shown while waiting for API results #166

WesleyBranton opened this issue Sep 24, 2020 · 0 comments · Fixed by #169
Assignees
Labels
Bug Something isn't working

Comments

@WesleyBranton
Copy link
Collaborator

Likely because of my changes in pull request #159 to address issue #153, questions that have replies but are still within the 24 hour period are popping up on the list UI from the time the API call is made until the time that all of the API calls are returned. To be honest, I can't really pinpoint exactly where the issue is happening.

However, I already started a rewrite of some of the question list storage code, so I'll just work the solution for issue #153 into that so that it will wipe out this bug. On the plus side, everything seems to be running a little faster with some of the rewrite stuff I've already done.

Mostly I've just been simplifying the code to replace some of the loops with the cleaner array operations like findIndex() and filter(). I already have a local test version done, so I'll do some testing with it running in the browser tomorrow and, if it works as expected, will submit a PR.

@WesleyBranton WesleyBranton added the Bug Something isn't working label Sep 24, 2020
@WesleyBranton WesleyBranton self-assigned this Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant