Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic running working #1

Merged
merged 6 commits into from
May 9, 2024
Merged

Basic running working #1

merged 6 commits into from
May 9, 2024

Conversation

richfitz
Copy link
Member

@richfitz richfitz commented May 3, 2024

This PR just throws together enough of the idea of basic model running so that we can sensibly discuss the next features. Notably missing but coming in the next few PRs:

  • More than one block of particles (we'll do this sooner rather than later)
  • Interesting time handling, allowing steps of size dt (where 1/dt is an integer)
  • Error handling
  • Parallelism
  • Comparison with data, resampling
  • Generation of the wrapper code (contents of src/walk.cpp, which can be generated easily)
  • Design and generation of an interface for the R side (all the dust2_walk functions)

Also the current version just uses the walk model which is special because it has 1d state, so we'll need to improve handling of state passing back and forth by putting some dimensions on input and output

Copy link
Contributor

@weshinsley weshinsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK - Think I get all of this!

@weshinsley weshinsley merged commit eead112 into main May 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants