Overhaul state/particle/group subset from history #103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How this is 700 lines I don't know. It was fiddly though.
This PR looks at extracting state from the filters with
dust_likelihood_last_history
anddust_likelihood_last_state
. There are two related problems.index_group
to subset by group. But this was problematic because it depended on theindex_group
passed intodust_likelihood_run()
! I have removed theindex_group
argument from these and they return the groups that we ran with originally which is pretty much always what is wanted, and more advanced use will be rare enough that we can either implement it when asked or people can subset manually.index_state
goes from filter creation to filter running. This requires a small dance so that we can ensure that the filter is created before we validate the index but that in turn tidies up my least favourite part of the monty initialisation. We might export the little "ensure initialised" function I have written there later. This keeps the two index arguments together which is nice.The PR is large because: