Comparison with data #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richfitz
force-pushed
the
mrc-5326
branch
5 times, most recently
from
c1dd49f to
f2fa476
Compare
This was referenced May 13, 2024
weshinsley
approved these changes
May 15, 2024
| const auto k = n_particles_ * i + j; | ||
| const auto offset = k * n_state_; | ||
| *it = T::compare_data(time_, dt_, state_data + offset, data[i], | ||
| shared_[i], internal_[i], rng_.state(k)); |
There was a problem hiding this comment.
So *it is the iterator here, and you can keep doing *it = to collect the results from subsequent comparisons?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge after #1, #3, #6, contains those commits.
This PR adds some support for comparing model output to data, via a
compare_datafunction. This is one of the ingredients required before we support particle filters