Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export state with dimension attribute #6

Merged
merged 4 commits into from
May 13, 2024
Merged

Export state with dimension attribute #6

merged 4 commits into from
May 13, 2024

Conversation

richfitz
Copy link
Member

@richfitz richfitz commented May 10, 2024

Merge after #3, contains those commits.

This PR allows export of state as a multidimensional matrix. The export code potentially fairly interesting, using the c++ initializer list in place of a variadic arg which is new to me, but seems to be fairly concise and easy to read. We'll use this approach for saving the trajectories over time too.

@richfitz richfitz mentioned this pull request May 10, 2024
@richfitz richfitz marked this pull request as ready for review May 10, 2024 14:14
@richfitz richfitz mentioned this pull request May 10, 2024
@richfitz richfitz requested a review from weshinsley May 10, 2024 15:54
Copy link
Contributor

@weshinsley weshinsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, all looking good

@weshinsley weshinsley merged commit abe450f into main May 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants