-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(arena): improved pool creation flow #1099
base: develop
Are you sure you want to change the base?
Conversation
k0beLeenders
commented
Feb 27, 2025
•
edited
Loading
edited
- moved images back to gcp
- new image upload flow added
- fixed a bug in oracle adding ix to bank
- adjusted to the new /pool/register endpoint
- fixed referral fee ata creation bug
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
🤖 Meticulous simulated 50 user flows and took 203 visual snapshots. Meticulous has not yet run on 11ba7cb of the main branch and so there was nothing to compare against. If you recently setup Meticulous, this is expected. Meticulous will start reporting comparisons for new pull requests after the next commit to the main branch. If you are using Vercel, please make sure you have disabled automatic job cancellation as documented here. Last updated for commit 16bf76f. This comment will update as new commits are pushed. |
67f7ec3
to
5b169db
Compare
- removed unnecessary api call to birdeye - replaced img tags with next/Image - hooked up gcp
- fixed a bug in oracle adding ix to bank - added image upload functionality - adjusted to the new /pool/register endpoint - fixed referral fee ata creation bug
5b169db
to
16bf76f
Compare
// Check if the file already exists | ||
const [exists] = await file.exists(); | ||
if (exists) { | ||
res.status(409).json({ message: "File already exists" }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this handled 'graceful'? Cause if the file already exists, we shouldnt error out the flow right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well if the image exists it can be reused for tokens in multiple pools. agree need to make sure the frontend handles receiving a 409 gracefully and just continue the process.
return []; | ||
} | ||
|
||
console.log("tx", tx); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove