feat: Add account authority transfer wrapper #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
losman0s
previously requested changes
Feb 1, 2024
|
The IDL is currently broken -- it needs to be auto-generated and added in the correct instruction |
Signed-off-by: denton <denton24646@gmail.com>
exdx
force-pushed
the
feat/account-authority-transfer
branch
from
e047890 to
e3e5b66
Compare
Signed-off-by: denton <denton24646@gmail.com>
Signed-off-by: denton <denton24646@gmail.com>
Signed-off-by: Denton X <dan@mrgn.group>
Signed-off-by: denton <denton24646@gmail.com>
Signed-off-by: denton <denton24646@gmail.com>
Signed-off-by: denton <denton24646@gmail.com>
Signed-off-by: Denton X <dan@mrgn.group>
Signed-off-by: denton <denton24646@gmail.com>
Signed-off-by: denton <denton24646@gmail.com>
Signed-off-by: denton <denton24646@gmail.com>
exdx
force-pushed
the
feat/account-authority-transfer
branch
from
6f802ff to
29c3872
Compare
exdx
commented
Feb 7, 2024
Comment on lines
-1894
to
+2122
| "name": "oracleKeys", | ||
| "type": { | ||
| "array": ["publicKey", 5] | ||
| } | ||
| "name": "oracleKey", | ||
| "type": "publicKey" |
There was a problem hiding this comment.
Is this ok or a breaking change? Not sure why the diff.
There was a problem hiding this comment.
Technically this is a breaking change, but one localized to an admin instruction, so only drawback would be to have to
- adapt any client making use of it (e.g. the squads UI which is anyway not ready on that side), and
- use a versioned approach to indexing past txs using this struct, which is a very minor use case
So it's fine
| @@ -1306,7 +1533,7 @@ | |||
| { | |||
| "name": "accountFlags", | |||
| "docs": [ | |||
| "The flas that indicates the state of the account.", | |||
| "The flags that indicate the state of the account.", | |||
There was a problem hiding this comment.
I assume this is safe to change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to create the new transfer account authority ix from the TS API.
See mrgnlabs/marginfi-v2#163 for more information on the implementation.
Signed-off-by: denton denton24646@gmail.com