Skip to content

Commit

Permalink
Do not cover non-None return
Browse files Browse the repository at this point in the history
For the following signals:
- onenter{STATE}_sig
- onchangestate_sig
- onafter{EVENT}_sig
- onreenter{STATE}_sig

The return values of the corresponding helper functions is not checked
by fysom.
  • Loading branch information
sjlongland committed Jan 24, 2016
1 parent 816bf70 commit 67a188e
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/main/python/fysom/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,7 @@ def _after_event(self, e):
if HAVE_SIGNALSLOT:
signame = 'onafter' + e.event + '_sig'
res = getattr(self, signame).emit(event=e)
if res is not None:
if res is not None: # pragma: no cover
return res
for fnname in ['onafter' + e.event, 'on' + e.event]:
if hasattr(self, fnname):
Expand Down Expand Up @@ -399,7 +399,7 @@ def _enter_state(self, e):
if HAVE_SIGNALSLOT:
signame = 'onenter' + e.dst + '_sig'
res = getattr(self, signame).emit(event=e)
if res is not None:
if res is not None: # pragma: no cover
return res
for fnname in ['onenter' + e.dst, 'on' + e.dst]:
if hasattr(self, fnname):
Expand All @@ -414,7 +414,7 @@ def _reenter_state(self, e):
if HAVE_SIGNALSLOT:
signame = fnname + '_sig'
res = getattr(self, signame).emit(event=e)
if res is not None:
if res is not None: # pragma: no cover
return res
if hasattr(self, fnname):
return getattr(self, fnname)(e)
Expand All @@ -427,7 +427,7 @@ def _change_state(self, e):
if HAVE_SIGNALSLOT:
signame = fnname + '_sig'
res = getattr(self, signame).emit(event=e)
if res is not None:
if res is not None: # pragma: no cover
return res

if hasattr(self, fnname):
Expand Down

0 comments on commit 67a188e

Please sign in to comment.