-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
signalslot integration #29
base: master
Are you sure you want to change the base?
Conversation
If detected, fysom will create `signalslot.Signal` instances for each of the events. The signals have the suffix `_sig` appended to them, to differentiate them from the callback names.
For the following signals: - onenter{STATE}_sig - onchangestate_sig - onafter{EVENT}_sig - onreenter{STATE}_sig The return values of the corresponding helper functions is not checked by fysom.
This probably needs to be fixed in signalslot actually, but for now, this will do.
d3c2f4b
to
305f4ac
Compare
Seems map() won't unconditionally iterate over its arguments. Another Python 3 vs 2 difference bites me in the nether regions.
Okay, the Python 3.3 failure is due to a bug in The commit 305f4ac can probably be reverted once Numergy/signalslot#11 is merged. A TODO item is figuring out how to skip the |
signalslot should pull this in by itself now.
Okay, upstream Soon as a new release of |
At long last, there's an update to |
Finally pulled my finger out and had a look at fixing #23.
I nicked the callback tests and re-worked them to use signals instead. I haven't added tests that combine callbacks and signals at this point, I figure people will likely use one or the other, but in theory, mixing them should work, it'll execute the signals before the callbacks.