You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add more verbs scraped from another repository (#131)
We ran into more missing verbs. So I figured instead of adding them a
few at a time when we run into issues, let's investigate what we
actually have used historically and batch add them. I did the
following for our largest repository, this is the only place where we
currently enforce git commit message style with this action:
https://github.com/mullvad/mullvadvpn-app/.
I grabbed all the first words from the subject line of our commits:
```bash
git log --format=%s | \
awk '{print tolower($1)}' | \
tr -cd '\n[:alnum:]._-' | \
sort -u > first-words
```
I then filtered out the ones not already in
`mostFrequentEnglishVerbs.ts`:
```bash
for word in $(cat first-words);
do
if ! grep -x " '$word'," mostFrequentEnglishVerbs.ts > /dev/null;
then
echo "$word";
fi;
done
```
I then manually went through the list of words. Many of them
were not even verbs, or verbs not in imperative form, since we have not
enforced this style before. But many of them are perfectly fine
imperative form verbs, so we add them to the list.
0 commit comments