Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use selene for linting in CI #291

Merged
merged 3 commits into from
Feb 18, 2025

Conversation

Ferenc-
Copy link
Contributor

@Ferenc- Ferenc- commented Feb 16, 2025

Unlike luacheck selene is acively maintained
and not known for false positives.

@mrjones2014
Copy link
Owner

I'm fine with it if you also update flake.nix, flake.lock, remove .luacheckrc, run selene and fix any formatting errors.

Unlike `luacheck`  `selene` is acively maintained
and not known for false positives.

Signed-off-by: Ferenc Géczi <ferenc.gm@gmail.com>
Signed-off-by: Ferenc Géczi <ferenc.gm@gmail.com>
Signed-off-by: Ferenc Géczi <ferenc.gm@gmail.com>
@Ferenc- Ferenc- force-pushed the run-selene branch 2 times, most recently from 57045e3 to 1f26cbe Compare February 18, 2025 09:39
@Ferenc-
Copy link
Contributor Author

Ferenc- commented Feb 18, 2025

I'm fine with it if you also update flake.nix, flake.lock, remove .luacheckrc, run selene and fix any formatting errors.

Done. Please check.

@mrjones2014 mrjones2014 merged commit de1d5ed into mrjones2014:master Feb 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants