Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shading on CNC shape models #407

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Montandalar
Copy link

Luanti 5.11 showed a lot of flaws in the shading of the CNC models, some of which were previously obscured. Fix the models so that smooth shading is applied where appropriate and sharp/flat shading where appropriate. The modified files have also been run through ExeVirus' CompressObj.

This PR cherry-pick of minetest-mods/technic#661 done for your convenience. Please see that PR for the spreadsheet with rationales and the before/after screenshot.

Luanti 5.11 showed a lot of flaws in the shading of the CNC models, some
of which were previously obscured. Fix the models so that smooth shading
is applied where appropriate and sharp/flat shading where appropriate.
The modified files have also been run through ExeVirus' CompressObj.
@Montandalar
Copy link
Author

Mineunit failing but I didn't change the code at all...

Copy link
Member

@BuckarooBanzay BuckarooBanzay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@S-S-X
Copy link
Member

S-S-X commented Feb 25, 2025

Mineunit failing but I didn't change the code at all...

Two failing tests are for #400 and #399 and were failing before this one, so not caused by this PR.

241 successes / 2 failures / 0 errors / 4 pending

Failure → spec/api_spec.lua @ 42
Technic API Machine registration registers my_mod:my_solar_array
spec/api_spec.lua:86: Expected objects to be equal.
Passed in:
(table: 0x7fb5652e8650) { }
Expected:
(table: 0x7fb5652e8060) { }

Failure → spec/other_spec.lua @ 45
Coal alloy furnace wont crash without placement callbacks
spec/other_spec.lua:48: Expected no error, but caught:
(string) 'bad argument #1 to 'ipairs' (table expected, got nil)'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants