-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add docker support #12
base: master
Are you sure you want to change the base?
Conversation
Hi @llitfkitfk Thank you very much for your input! Shall I ask you to fix the Travis build as well? |
Another comment, any reason why you've enabled "go mod"? I wouldn't say no, but not as a part of this PR. |
go mod for docker build |
if some dependencies have breaking changes, docker build could be failed I think |
Generally l'm fine with your changes, but please fix the build on Travis, then I will merge it. Thanks! |
I think go mod need added the first time |
Ok @llitfkitfk, so kindly please prepare a PR (with go mod only) that passes the Travis build. BTW Later on, you can update README file with section about Docker. |
No description provided.