Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docker support #12

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

llitfkitfk
Copy link

No description provided.

@llitfkitfk llitfkitfk mentioned this pull request Jan 10, 2019
@mtojek
Copy link
Owner

mtojek commented Jan 10, 2019

Hi @llitfkitfk

Thank you very much for your input! Shall I ask you to fix the Travis build as well?

@mtojek
Copy link
Owner

mtojek commented Jan 10, 2019

Another comment, any reason why you've enabled "go mod"? I wouldn't say no, but not as a part of this PR.

@llitfkitfk
Copy link
Author

go mod for docker build
download dependencies and build greenwall command

@llitfkitfk
Copy link
Author

if some dependencies have breaking changes, docker build could be failed I think

@mtojek
Copy link
Owner

mtojek commented Jan 11, 2019

Generally l'm fine with your changes, but please fix the build on Travis, then I will merge it. Thanks!

@llitfkitfk
Copy link
Author

I think go mod need added the first time

@mtojek
Copy link
Owner

mtojek commented Jan 11, 2019

Ok @llitfkitfk, so kindly please prepare a PR (with go mod only) that passes the Travis build.

BTW Later on, you can update README file with section about Docker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants