Skip to content

iOS end to end workflow changes related to iOS 17 and iPad #5024

iOS end to end workflow changes related to iOS 17 and iPad

iOS end to end workflow changes related to iOS 17 and iPad #5024

Triggered via pull request July 22, 2024 11:33
Status Success
Total duration 5m 2s
Artifacts

ios.yml

on: pull_request
Check formatting
39s
Run swiftlint
23s
Unit tests
4m 53s

Annotations

25 warnings
Run swiftlint
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run swiftlint
swiftlint 0.55.1 is already installed and up-to-date. To reinstall 0.55.1, run: brew reinstall swiftlint
Run swiftlint: PacketTunnel/PacketTunnelProvider/PacketTunnelProvider.swift#L38
Function body should span 50 lines or less excluding comments and whitespace: currently spans 55 lines (function_body_length)
Run swiftlint: MullvadSettings/SettingsManager.swift#L51
Prefer using UTF-8 encoded strings when converting between `String` and `Data` (non_optional_string_data_conversion)
Run swiftlint: MullvadVPNUITests/ConnectivityTests.swift#L54
Function body should span 50 lines or less excluding comments and whitespace: currently spans 53 lines (function_body_length)
Run swiftlint: MullvadVPNTests/MullvadSettings/IPOverrideRepositoryTests.swift#L17
Prefer `static` over `final class` (static_over_final_class)
Run swiftlint: MullvadVPNTests/MullvadSettings/IPOverrideRepositoryTests.swift#L21
Prefer `static` over `final class` (static_over_final_class)
Run swiftlint: MullvadVPNTests/MullvadSettings/MigrationManagerTests.swift#L75
Prefer using UTF-8 encoded strings when converting between `String` and `Data` (non_optional_string_data_conversion)
Run swiftlint: MullvadVPNTests/MullvadSettings/MigrationManagerTests.swift#L19
Prefer `static` over `final class` (static_over_final_class)
Run swiftlint: MullvadVPNTests/MullvadSettings/MigrationManagerTests.swift#L23
Prefer `static` over `final class` (static_over_final_class)
Run swiftlint: MullvadVPNTests/MullvadSettings/APIAccessMethodsTests.swift#L16
Prefer `static` over `final class` (static_over_final_class)
Check formatting
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Check formatting
swiftformat 0.54.1 already installed
Unit tests
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, actions/cache@v3, actions/setup-go@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Unit tests: --- xcodebuild#L1
Using the first of multiple matching destinations:
Unit tests
xcbeautify 2.4.1 is already installed and up-to-date. To reinstall 2.4.1, run: brew reinstall xcbeautify