Allow relay selector to filter daita enabled relays #5112
rabladorAnnotations
3 errors and 15 warnings
|
Check formatting
Process completed with exit code 1.
|
|
Unit tests
xcodebuild: error: Could not resolve package dependencies:
|
|
Unit tests
Process completed with exit code 74.
|
|
Run swiftlint
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Run swiftlint
swiftlint 0.55.1 is already installed and up-to-date.
To reinstall 0.55.1, run:
brew reinstall swiftlint
|
|
Run swiftlint:
MullvadSettings/SettingsManager.swift#L51
Prefer using UTF-8 encoded strings when converting between `String` and `Data` (non_optional_string_data_conversion)
|
|
Run swiftlint:
MullvadVPNUITests/ConnectivityTests.swift#L53
A doc comment should be attached to a declaration (orphaned_doc_comment)
|
|
Run swiftlint:
MullvadVPNTests/MullvadSettings/IPOverrideRepositoryTests.swift#L17
Prefer `static` over `final class` (static_over_final_class)
|
|
Run swiftlint:
MullvadVPNTests/MullvadSettings/IPOverrideRepositoryTests.swift#L21
Prefer `static` over `final class` (static_over_final_class)
|
|
Run swiftlint:
MullvadVPNTests/MullvadSettings/MigrationManagerTests.swift#L75
Prefer using UTF-8 encoded strings when converting between `String` and `Data` (non_optional_string_data_conversion)
|
|
Run swiftlint:
MullvadVPNTests/MullvadSettings/APIAccessMethodsTests.swift#L16
Prefer `static` over `final class` (static_over_final_class)
|
|
Run swiftlint:
MullvadVPNTests/MullvadSettings/APIAccessMethodsTests.swift#L20
Prefer `static` over `final class` (static_over_final_class)
|
|
Run swiftlint:
MullvadVPNTests/MullvadREST/Relay/RelaySelectorTests.swift#L232
Line should be 120 characters or less; currently it has 122 characters (line_length)
|
|
Run swiftlint:
PacketTunnelCoreTests/PacketTunnelActorTests.swift#L212
SwiftLint rule 'function_body_length' did not trigger a violation in the disabled region; remove the disable command (superfluous_disable_command)
|
|
Check formatting
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Check formatting
swiftformat 0.54.3 already installed
|
|
Unit tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/cache@v3, actions/setup-go@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Unit tests
xcbeautify 2.10.0 is already installed and up-to-date.
To reinstall 2.10.0, run:
brew reinstall xcbeautify
|