Skip to content
iOS app

Decouple DNS server info from content-blockers UI expansion #6311

Sign in to view logs

Decouple DNS server info from content-blockers UI expansion

Decouple DNS server info from content-blockers UI expansion #6311

Triggered via pull request March 10, 2025 15:54
@acb-mvacb-mv
opened #7791
ios-1051-use-custom-dns-label-constancy
Status Success
Total duration 7m 15s
Billable time 8m
Artifacts 1

ios.yml

on: pull_request
Check formatting
38s
Check formatting
Run swiftlint
26s
Run swiftlint
Unit tests
7m 5s
Unit tests
Fit to window
Zoom out
Zoom in

Annotations

21 warnings
Run swiftlint: PacketTunnel/PacketTunnelProvider/PacketTunnelProvider.swift#L423
File should contain 400 lines or less: currently contains 423 (file_length)
Run swiftlint: PacketTunnelCoreTests/MultiHopEphemeralPeerExchangerTests.swift#L163
Unused parameter in a closure should be replaced with _ (unused_closure_parameter)
Run swiftlint: MullvadREST/ApiHandlers/RESTResponseHandler.swift#L26
TODOs should be resolved (We could probably remove the `...) (todo)
Run swiftlint: MullvadVPN/Coordinators/Settings/SettingsCoordinator.swift#L45
Sendable conformance is redundant on an actor-isolated type (redundant_sendable)
Run swiftlint: MullvadVPN/Coordinators/ApplicationCoordinator.swift#L839
File should contain 400 lines or less: currently contains 839 (file_length)
Run swiftlint: MullvadVPN/Coordinators/CustomLists/EditLocationsCoordinator.swift#L16
Sendable conformance is redundant on an actor-isolated type (redundant_sendable)
Run swiftlint: MullvadVPN/SimulatorTunnelProvider/SimulatorTunnelProviderHost.swift#L113
Function body should span 50 lines or less excluding comments and whitespace: currently spans 63 lines (function_body_length)
Run swiftlint: MullvadVPN/View controllers/Settings/SettingsCellFactory.swift#L17
Sendable conformance is redundant on an actor-isolated type (redundant_sendable)
Run swiftlint: MullvadVPN/View controllers/VPNSettings/VPNSettingsInfoButtonItem.swift#L28
Line should be 120 characters or less; currently it has 128 characters (line_length)
Run swiftlint: MullvadVPN/View controllers/VPNSettings/VPNSettingsViewController.swift#L174
Lines should not have trailing whitespace (trailing_whitespace)
Check formatting
swiftformat 0.55.5 already installed
Unit tests: Users/runner/Library/Developer/Xcode/DerivedData/MullvadVPN-eyvrfmadodhkonbxvnjzkuyudpjl/Build/Intermediates.noindex/MullvadVPN.build/Debug-iphonesimulator/MullvadRustRuntime.build/module.private.modulemap#L1
expected canonical name for private module 'MullvadRustRuntimeProxy'
Unit tests: Users/runner/Library/Developer/Xcode/DerivedData/MullvadVPN-eyvrfmadodhkonbxvnjzkuyudpjl/Build/Intermediates.noindex/MullvadVPN.build/Debug-iphonesimulator/MullvadRustRuntime.build/module.private.modulemap#L1
expected canonical name for private module 'MullvadRustRuntimeProxy'
Unit tests: Users/runner/Library/Developer/Xcode/DerivedData/MullvadVPN-eyvrfmadodhkonbxvnjzkuyudpjl/Build/Intermediates.noindex/MullvadVPN.build/Debug-iphonesimulator/MullvadRustRuntime.build/module.private.modulemap#L1
expected canonical name for private module 'MullvadRustRuntimeProxy'
Unit tests: Users/runner/Library/Developer/Xcode/DerivedData/MullvadVPN-eyvrfmadodhkonbxvnjzkuyudpjl/Build/Intermediates.noindex/MullvadVPN.build/Debug-iphonesimulator/MullvadRustRuntime.build/module.private.modulemap#L1
expected canonical name for private module 'MullvadRustRuntimeProxy'
Unit tests: Users/runner/Library/Developer/Xcode/DerivedData/MullvadVPN-eyvrfmadodhkonbxvnjzkuyudpjl/Build/Intermediates.noindex/MullvadVPN.build/Debug-iphonesimulator/MullvadRustRuntime.build/module.private.modulemap#L1
expected canonical name for private module 'MullvadRustRuntimeProxy'
Unit tests: Users/runner/Library/Developer/Xcode/DerivedData/MullvadVPN-eyvrfmadodhkonbxvnjzkuyudpjl/Build/Intermediates.noindex/MullvadVPN.build/Debug-iphonesimulator/MullvadRustRuntime.build/module.private.modulemap#L1
expected canonical name for private module 'MullvadRustRuntimeProxy'
Unit tests: Users/runner/Library/Developer/Xcode/DerivedData/MullvadVPN-eyvrfmadodhkonbxvnjzkuyudpjl/Build/Intermediates.noindex/MullvadVPN.build/Debug-iphonesimulator/MullvadRustRuntime.build/module.private.modulemap#L1
expected canonical name for private module 'MullvadRustRuntimeProxy'
Unit tests: Users/runner/Library/Developer/Xcode/DerivedData/MullvadVPN-eyvrfmadodhkonbxvnjzkuyudpjl/Build/Intermediates.noindex/MullvadVPN.build/Debug-iphonesimulator/MullvadRustRuntime.build/module.private.modulemap#L1
expected canonical name for private module 'MullvadRustRuntimeProxy'
Unit tests: Users/runner/Library/Developer/Xcode/DerivedData/MullvadVPN-eyvrfmadodhkonbxvnjzkuyudpjl/Build/Intermediates.noindex/MullvadVPN.build/Debug-iphonesimulator/MullvadRustRuntime.build/module.private.modulemap#L1
expected canonical name for private module 'MullvadRustRuntimeProxy'
Unit tests: Users/runner/Library/Developer/Xcode/DerivedData/MullvadVPN-eyvrfmadodhkonbxvnjzkuyudpjl/Build/Intermediates.noindex/MullvadVPN.build/Debug-iphonesimulator/MullvadRustRuntime.build/module.private.modulemap#L1
expected canonical name for private module 'MullvadRustRuntimeProxy'

Artifacts

Produced during runtime
Name Size Digest
test-report
1.14 MB
sha256:3c68fcda0c6650ad5857fb73a9f2025d361f4243a31a7155114dccc704c1efe7