iOS app

Improve TV connect screen UI #6332

Sign in to view logs

Triggered via pull request March 19, 2025 08:23

kl

synchronize #7795

improve-tv-ui-experience

Status Success

Total duration 11m 6s

Billable time 8m

Artifacts 1

ios.yml

on: pull_request

Check formatting

Annotations

20 warnings

Run swiftlint: PacketTunnel/PacketTunnelProvider/PacketTunnelProvider.swift#L423

File should contain 400 lines or less: currently contains 423 (file_length)

Run swiftlint: PacketTunnelCoreTests/MultiHopEphemeralPeerExchangerTests.swift#L163

Unused parameter in a closure should be replaced with _ (unused_closure_parameter)

Run swiftlint: MullvadREST/ApiHandlers/RESTResponseHandler.swift#L26

TODOs should be resolved (We could probably remove the `...) (todo)

Run swiftlint: MullvadVPN/Coordinators/Settings/SettingsCoordinator.swift#L45

Sendable conformance is redundant on an actor-isolated type (redundant_sendable)

Run swiftlint: MullvadVPN/Coordinators/ApplicationCoordinator.swift#L842

File should contain 400 lines or less: currently contains 842 (file_length)

Run swiftlint: MullvadVPN/Coordinators/CustomLists/EditLocationsCoordinator.swift#L16

Sendable conformance is redundant on an actor-isolated type (redundant_sendable)

Run swiftlint: MullvadVPN/SimulatorTunnelProvider/SimulatorTunnelProviderHost.swift#L113

Function body should span 50 lines or less excluding comments and whitespace: currently spans 63 lines (function_body_length)

Run swiftlint: MullvadVPN/View controllers/Settings/SettingsCellFactory.swift#L17

Sendable conformance is redundant on an actor-isolated type (redundant_sendable)

Run swiftlint: MullvadVPN/View controllers/VPNSettings/VPNSettingsInfoButtonItem.swift#L28

Line should be 120 characters or less; currently it has 128 characters (line_length)

Run swiftlint: MullvadVPN/View controllers/VPNSettings/VPNSettingsViewController.swift#L174

Lines should not have trailing whitespace (trailing_whitespace)

Unit tests: Users/runner/Library/Developer/Xcode/DerivedData/MullvadVPN-eyvrfmadodhkonbxvnjzkuyudpjl/Build/Intermediates.noindex/MullvadVPN.build/Debug-iphonesimulator/MullvadRustRuntime.build/module.private.modulemap#L1

expected canonical name for private module 'MullvadRustRuntimeProxy'

Unit tests: Users/runner/Library/Developer/Xcode/DerivedData/MullvadVPN-eyvrfmadodhkonbxvnjzkuyudpjl/Build/Intermediates.noindex/MullvadVPN.build/Debug-iphonesimulator/MullvadRustRuntime.build/module.private.modulemap#L1

expected canonical name for private module 'MullvadRustRuntimeProxy'

Unit tests: Users/runner/Library/Developer/Xcode/DerivedData/MullvadVPN-eyvrfmadodhkonbxvnjzkuyudpjl/Build/Intermediates.noindex/MullvadVPN.build/Debug-iphonesimulator/MullvadRustRuntime.build/module.private.modulemap#L1

expected canonical name for private module 'MullvadRustRuntimeProxy'

Unit tests: Users/runner/Library/Developer/Xcode/DerivedData/MullvadVPN-eyvrfmadodhkonbxvnjzkuyudpjl/Build/Intermediates.noindex/MullvadVPN.build/Debug-iphonesimulator/MullvadRustRuntime.build/module.private.modulemap#L1

expected canonical name for private module 'MullvadRustRuntimeProxy'

Unit tests: Users/runner/Library/Developer/Xcode/DerivedData/MullvadVPN-eyvrfmadodhkonbxvnjzkuyudpjl/Build/Intermediates.noindex/MullvadVPN.build/Debug-iphonesimulator/MullvadRustRuntime.build/module.private.modulemap#L1

expected canonical name for private module 'MullvadRustRuntimeProxy'

Unit tests: Users/runner/Library/Developer/Xcode/DerivedData/MullvadVPN-eyvrfmadodhkonbxvnjzkuyudpjl/Build/Intermediates.noindex/MullvadVPN.build/Debug-iphonesimulator/MullvadRustRuntime.build/module.private.modulemap#L1

expected canonical name for private module 'MullvadRustRuntimeProxy'

Unit tests: Users/runner/Library/Developer/Xcode/DerivedData/MullvadVPN-eyvrfmadodhkonbxvnjzkuyudpjl/Build/Intermediates.noindex/MullvadVPN.build/Debug-iphonesimulator/MullvadRustRuntime.build/module.private.modulemap#L1

expected canonical name for private module 'MullvadRustRuntimeProxy'

Unit tests: Users/runner/Library/Developer/Xcode/DerivedData/MullvadVPN-eyvrfmadodhkonbxvnjzkuyudpjl/Build/Intermediates.noindex/MullvadVPN.build/Debug-iphonesimulator/MullvadRustRuntime.build/module.private.modulemap#L1

expected canonical name for private module 'MullvadRustRuntimeProxy'

Unit tests: ios/MullvadREST/Transport/Direct/URLSessionTransport.swift#L12

extension declares a conformance of imported type 'URLSessionTask' to imported protocol 'Cancellable'; this will not behave correctly if the owners of 'Foundation' introduce this conformance in the future

Unit tests: Users/runner/Library/Developer/Xcode/DerivedData/MullvadVPN-eyvrfmadodhkonbxvnjzkuyudpjl/Build/Intermediates.noindex/MullvadVPN.build/Debug-iphonesimulator/MullvadRustRuntime.build/module.private.modulemap#L1

expected canonical name for private module 'MullvadRustRuntimeProxy'

Artifacts

Produced during runtime

Name	Size	Digest
test-report	1.24 MB	`sha256:c50bb9113a0cf561c30dd951a93d2671341c03518c8131765c98ab96be66b3b5`