Skip to content

Add UI for adding and editing a custom list #4248

Add UI for adding and editing a custom list

Add UI for adding and editing a custom list #4248

Triggered via pull request February 16, 2024 12:13
Status Success
Total duration 4m 53s
Artifacts
This run and associated checks have been archived and are scheduled for deletion. Learn more about checks retention

ios.yml

on: pull_request
Check formatting
36s
Check formatting
Run swiftlint
23s
Run swiftlint
Unit tests
4m 44s
Unit tests
Fit to window
Zoom out
Zoom in

Annotations

14 warnings
Run swiftlint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Run swiftlint: MullvadVPN/Coordinators/CustomLists/CustomListViewController.swift#L150
TODOs should be resolved (Show error dialog.) (todo)
Run swiftlint: MullvadVPN/Coordinators/CustomLists/AddCustomListCoordinator.swift#L72
TODOs should be resolved (Show view controller for locat...) (todo)
Run swiftlint: MullvadVPN/Coordinators/CustomLists/EditCustomListCoordinator.swift#L70
TODOs should be resolved (Show view controller for locat...) (todo)
Check formatting
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Unit tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3, actions/setup-go@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Unit tests: --- xcodebuild#L1
Using the first of multiple matching destinations:
Unit tests
SwiftLint not installed, download from https://github.com/realm/SwiftLint
Unit tests: ld#L1
'/Users/runner/Library/Developer/Xcode/DerivedData/MullvadVPN-eyvrfmadodhkonbxvnjzkuyudpjl/Build/Products/Debug-iphonesimulator/libwg-go.a[arm64][2](go.o)' has malformed LC_DYSYMTAB, expected 61 undefined symbols to start at index 4702, found 73 undefined symbols starting at index 15
Unit tests
SwiftLint not installed, download from https://github.com/realm/SwiftLint
Unit tests: ios/MullvadVPNTests/CustomListRepositoryTests.swift#L42
variable 'item' was never mutated; consider changing to 'let' constant
Unit tests: ios/MullvadVPNTests/CustomListRepositoryTests.swift#L55
variable 'item' was never mutated; consider changing to 'let' constant
Unit tests: ios/MullvadVPNTests/CustomListRepositoryTests.swift#L68
variable 'streaming' was never mutated; consider changing to 'let' constant
Unit tests: ios/MullvadVPNTests/CustomListRepositoryTests.swift#L74
initialization of variable 'gaming' was never used; consider replacing with assignment to '_' or removing it