Skip to content
iOS app

Consolidate iOS rust code into a single crate #5008

Sign in to view logs

Consolidate iOS rust code into a single crate

Consolidate iOS rust code into a single crate #5008

Triggered via pull request July 16, 2024 14:01
@pinkisemilspinkisemils
synchronize #6458
reuse-the-same-tokio-runtime-in-packettunnel-ios-596
Status Failure
Total duration 5m 0s
Artifacts –

ios.yml

on: pull_request
Check formatting
39s
Run swiftlint
30s
Unit tests
2m 15s

Annotations

10 errors and 23 warnings
Unit tests: ios/PacketTunnelCore/Actor/PacketTunnelActor.swift#L46
cannot find type 'RelaySelectorProtocol' in scope
Unit tests: ios/PacketTunnelCore/Actor/PacketTunnelActor.swift#L58
cannot find type 'RelaySelectorProtocol' in scope
Unit tests: ios/PacketTunnelCore/Actor/PacketTunnelActor.swift#L456
cannot find type 'SelectedRelays' in scope
Unit tests: ios/PacketTunnelCore/Actor/PacketTunnelActor.swift#L454
cannot find type 'SelectedRelays' in scope
Unit tests: ios/PacketTunnelCore/Actor/State.swift#L239
cannot find type 'SelectedRelays' in scope
Unit tests: ios/PacketTunnelCore/Actor/State.swift#L113
cannot find type 'SelectedRelays' in scope
Unit tests: ios/PacketTunnelCore/Actor/State.swift#L111
type 'State.ConnectionData' does not conform to protocol 'Equatable'
Unit tests: ios/PacketTunnelCore/Actor/State.swift#L231
type 'NextRelays' does not conform to protocol 'Equatable'
Unit tests: ios/PacketTunnelCore/Actor/State.swift#L231
type 'NextRelays' does not conform to protocol 'Decodable'
Unit tests: ios/PacketTunnelCore/Actor/State.swift#L231
type 'NextRelays' does not conform to protocol 'Encodable'
Run swiftlint
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run swiftlint
swiftlint 0.55.1 is already installed and up-to-date. To reinstall 0.55.1, run: brew reinstall swiftlint
Run swiftlint: PacketTunnel/PacketTunnelProvider/PacketTunnelProvider.swift#L38
Function body should span 50 lines or less excluding comments and whitespace: currently spans 55 lines (function_body_length)
Run swiftlint: MullvadSettings/SettingsManager.swift#L51
Prefer using UTF-8 encoded strings when converting between `String` and `Data` (non_optional_string_data_conversion)
Run swiftlint: MullvadVPNTests/MullvadSettings/IPOverrideRepositoryTests.swift#L17
Prefer `static` over `final class` (static_over_final_class)
Run swiftlint: MullvadVPNTests/MullvadSettings/IPOverrideRepositoryTests.swift#L21
Prefer `static` over `final class` (static_over_final_class)
Run swiftlint: MullvadVPNTests/MullvadSettings/MigrationManagerTests.swift#L75
Prefer using UTF-8 encoded strings when converting between `String` and `Data` (non_optional_string_data_conversion)
Run swiftlint: MullvadVPNTests/MullvadSettings/MigrationManagerTests.swift#L19
Prefer `static` over `final class` (static_over_final_class)
Run swiftlint: MullvadVPNTests/MullvadSettings/MigrationManagerTests.swift#L23
Prefer `static` over `final class` (static_over_final_class)
Run swiftlint: MullvadVPNTests/MullvadSettings/APIAccessMethodsTests.swift#L16
Prefer `static` over `final class` (static_over_final_class)
Run swiftlint: MullvadVPNTests/MullvadSettings/APIAccessMethodsTests.swift#L20
Prefer `static` over `final class` (static_over_final_class)
Check formatting
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Unit tests
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, actions/cache@v3, actions/setup-go@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Unit tests: --- xcodebuild#L1
Using the first of multiple matching destinations:
Unit tests: Users/runner/Library/Developer/Xcode/DerivedData/MullvadVPN-eyvrfmadodhkonbxvnjzkuyudpjl/Build/Intermediates.noindex/MullvadVPN.build/Debug-iphonesimulator/MullvadRustRuntime.build/module.private.modulemap#L1
expected canonical name for private module 'MullvadRustRuntimeProxy'
Unit tests: Users/runner/Library/Developer/Xcode/DerivedData/MullvadVPN-eyvrfmadodhkonbxvnjzkuyudpjl/Build/Intermediates.noindex/MullvadVPN.build/Debug-iphonesimulator/MullvadRustRuntime.build/module.private.modulemap#L1
expected canonical name for private module 'MullvadRustRuntimeProxy'
Unit tests: Users/runner/Library/Developer/Xcode/DerivedData/MullvadVPN-eyvrfmadodhkonbxvnjzkuyudpjl/Build/Intermediates.noindex/MullvadVPN.build/Debug-iphonesimulator/MullvadRustRuntime.build/module.private.modulemap#L1
expected canonical name for private module 'MullvadRustRuntimeProxy'
Unit tests: Users/runner/Library/Developer/Xcode/DerivedData/MullvadVPN-eyvrfmadodhkonbxvnjzkuyudpjl/Build/Intermediates.noindex/MullvadVPN.build/Debug-iphonesimulator/MullvadRustRuntime.build/module.private.modulemap#L1
expected canonical name for private module 'MullvadRustRuntimeProxy'
Unit tests: Users/runner/Library/Developer/Xcode/DerivedData/MullvadVPN-eyvrfmadodhkonbxvnjzkuyudpjl/Build/Intermediates.noindex/MullvadVPN.build/Debug-iphonesimulator/MullvadRustRuntime.build/module.private.modulemap#L1
expected canonical name for private module 'MullvadRustRuntimeProxy' [-Wprivate-module]
Unit tests: Users/runner/Library/Developer/Xcode/DerivedData/MullvadVPN-eyvrfmadodhkonbxvnjzkuyudpjl/Build/Intermediates.noindex/MullvadVPN.build/Debug-iphonesimulator/MullvadRustRuntime.build/module.private.modulemap#L1
expected canonical name for private module 'MullvadRustRuntimeProxy'
Unit tests: Users/runner/Library/Developer/Xcode/DerivedData/MullvadVPN-eyvrfmadodhkonbxvnjzkuyudpjl/Build/Intermediates.noindex/MullvadVPN.build/Debug-iphonesimulator/MullvadRustRuntime.build/module.private.modulemap#L1
expected canonical name for private module 'MullvadRustRuntimeProxy'
Unit tests: Users/runner/Library/Developer/Xcode/DerivedData/MullvadVPN-eyvrfmadodhkonbxvnjzkuyudpjl/Build/Intermediates.noindex/MullvadVPN.build/Debug-iphonesimulator/MullvadRustRuntime.build/module.private.modulemap#L1
expected canonical name for private module 'MullvadRustRuntimeProxy'
Unit tests: Users/runner/Library/Developer/Xcode/DerivedData/MullvadVPN-eyvrfmadodhkonbxvnjzkuyudpjl/Build/Intermediates.noindex/MullvadVPN.build/Debug-iphonesimulator/MullvadRustRuntime.build/module.private.modulemap#L1
expected canonical name for private module 'MullvadRustRuntimeProxy'