-
Notifications
You must be signed in to change notification settings - Fork 392
/
Copy pathDeviceCheckOperationTests.swift
550 lines (444 loc) · 18.4 KB
/
DeviceCheckOperationTests.swift
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
//
// DeviceCheckOperationTests.swift
// MullvadVPNTests
//
// Created by pronebird on 30/05/2023.
// Copyright © 2023 Mullvad VPN AB. All rights reserved.
//
import MullvadREST
import MullvadSettings
import MullvadTypes
import Operations
@testable import PacketTunnel
import PacketTunnelCore
import WireGuardKitTypes
import XCTest
class DeviceCheckOperationTests: XCTestCase {
private let operationQueue = AsyncOperationQueue()
private let dispatchQueue = DispatchQueue(label: "TestQueue")
func testShouldReportExpiredAccount() {
let expect = expectation(description: "Wait for operation to complete")
let currentKey = PrivateKey()
let remoteService = MockRemoteService(
initialKey: currentKey.publicKey,
getAccount: { _ in
Account.mock(expiry: .distantPast)
}
)
let deviceStateAccessor = MockDeviceStateAccessor.mockLoggedIn(
currentKey: currentKey,
rotationState: .succeeded
)
startDeviceCheck(remoteService: remoteService, deviceStateAccessor: deviceStateAccessor) { result in
let deviceCheck = result.value
XCTAssertNotNil(deviceCheck)
XCTAssertTrue(deviceCheck?.accountVerdict.isExpired ?? false)
XCTAssert(deviceCheck?.keyRotationStatus == .noAction)
XCTAssertEqual(try? deviceStateAccessor.read().deviceData?.wgKeyData.privateKey, currentKey)
expect.fulfill()
}
waitForExpectations(timeout: 1)
}
func testShouldNotRotateKeyForInvalidAccount() {
let expect = expectation(description: "Wait for operation to complete")
let currentKey = PrivateKey()
let nextKey = PrivateKey()
let remoteService = MockRemoteService(
initialKey: currentKey.publicKey,
getAccount: { _ in
throw REST.Error.unhandledResponse(404, REST.ServerErrorResponse(code: .invalidAccount))
}
)
let deviceStateAccessor = MockDeviceStateAccessor.mockLoggedIn(
currentKey: currentKey,
rotationState: .failed(when: .retryInterval, nextKey: nextKey)
)
startDeviceCheck(remoteService: remoteService, deviceStateAccessor: deviceStateAccessor) { result in
let deviceCheck = result.value
XCTAssertNotNil(deviceCheck)
XCTAssert(deviceCheck?.accountVerdict == .invalid)
XCTAssert(deviceCheck?.keyRotationStatus == .noAction)
XCTAssertEqual(try? deviceStateAccessor.read().deviceData?.wgKeyData.privateKey, currentKey)
expect.fulfill()
}
waitForExpectations(timeout: 1)
}
func testShouldNotRotateKeyForRevokedDevice() {
let expect = expectation(description: "Wait for operation to complete")
let currentKey = PrivateKey()
let nextKey = PrivateKey()
let remoteService = MockRemoteService(
initialKey: currentKey.publicKey,
getDevice: { _, _ in
throw REST.Error.unhandledResponse(404, REST.ServerErrorResponse(code: .deviceNotFound))
}
)
let deviceStateAccessor = MockDeviceStateAccessor.mockLoggedIn(
currentKey: currentKey,
rotationState: .failed(when: .retryInterval, nextKey: nextKey)
)
startDeviceCheck(remoteService: remoteService, deviceStateAccessor: deviceStateAccessor) { result in
let deviceCheck = result.value
XCTAssertNotNil(deviceCheck)
XCTAssert(deviceCheck?.deviceVerdict == .revoked)
XCTAssert(deviceCheck?.keyRotationStatus == .noAction)
XCTAssertEqual(try? deviceStateAccessor.read().deviceData?.wgKeyData.privateKey, currentKey)
expect.fulfill()
}
waitForExpectations(timeout: 1)
}
func testShouldRotateKeyOnMismatchImmediately() {
let expect = expectation(description: "Wait for operation to complete")
let currentKey = PrivateKey()
let nextKey = PrivateKey()
let remoteService = MockRemoteService()
let deviceStateAccessor = MockDeviceStateAccessor.mockLoggedIn(
currentKey: currentKey,
rotationState: .failed(when: .packetTunnelCooldownInterval, nextKey: nextKey)
)
startDeviceCheck(
remoteService: remoteService,
deviceStateAccessor: deviceStateAccessor,
rotateImmediatelyOnKeyMismatch: true
) { result in
let deviceCheck = result.value
XCTAssertNotNil(deviceCheck)
XCTAssertTrue(deviceCheck?.keyRotationStatus.isSucceeded ?? false)
XCTAssertEqual(try? deviceStateAccessor.read().deviceData?.wgKeyData.privateKey, nextKey)
expect.fulfill()
}
waitForExpectations(timeout: 1)
}
func testShouldRespectCooldownWhenAttemptingToRotateImmediately() {
let expect = expectation(description: "Wait for operation to complete")
let currentKey = PrivateKey()
let nextKey = PrivateKey()
let remoteService = MockRemoteService()
let deviceStateAccessor = MockDeviceStateAccessor.mockLoggedIn(
currentKey: currentKey,
rotationState: .failed(when: .zero, nextKey: nextKey)
)
startDeviceCheck(
remoteService: remoteService,
deviceStateAccessor: deviceStateAccessor,
rotateImmediatelyOnKeyMismatch: true
) { result in
let deviceCheck = result.value
XCTAssertNotNil(deviceCheck)
XCTAssertEqual(deviceCheck?.keyRotationStatus, KeyRotationStatus.noAction)
XCTAssertEqual(try? deviceStateAccessor.read().deviceData?.wgKeyData.privateKey, currentKey)
expect.fulfill()
}
waitForExpectations(timeout: 1)
}
func testShouldNotRotateDeviceKeyWhenServerKeyIsIdentical() {
let expect = expectation(description: "Wait for operation to complete")
let currentKey = PrivateKey()
let remoteService = MockRemoteService(initialKey: currentKey.publicKey)
let deviceStateAccessor = MockDeviceStateAccessor.mockLoggedIn(
currentKey: currentKey,
rotationState: .succeeded
)
startDeviceCheck(remoteService: remoteService, deviceStateAccessor: deviceStateAccessor) { result in
let deviceCheck = result.value
XCTAssertNotNil(deviceCheck)
XCTAssertEqual(deviceCheck?.keyRotationStatus, KeyRotationStatus.noAction)
XCTAssertEqual(try? deviceStateAccessor.read().deviceData?.wgKeyData.privateKey, currentKey)
expect.fulfill()
}
waitForExpectations(timeout: 1)
}
func testShouldNotRotateKeyBeforeRetryIntervalPassed() {
let expect = expectation(description: "Wait for operation to complete")
let currentKey = PrivateKey()
let nextKey = PrivateKey()
let remoteService = MockRemoteService(initialKey: currentKey.publicKey)
let deviceStateAccessor = MockDeviceStateAccessor.mockLoggedIn(
currentKey: currentKey,
rotationState: .failed(when: .closeToRetryInterval, nextKey: nextKey)
)
startDeviceCheck(remoteService: remoteService, deviceStateAccessor: deviceStateAccessor) { result in
let deviceCheck = result.value
XCTAssertNotNil(deviceCheck)
XCTAssertEqual(deviceCheck?.keyRotationStatus, KeyRotationStatus.noAction)
XCTAssertEqual(try? deviceStateAccessor.read().deviceData?.wgKeyData.privateKey, currentKey)
expect.fulfill()
}
waitForExpectations(timeout: 1)
}
func testShouldRotateKeyOnceInTwentyFourHours() {
let expect = expectation(description: "Wait for operation to complete")
let currentKey = PrivateKey()
let nextKey = PrivateKey()
let remoteService = MockRemoteService()
let deviceStateAccessor = MockDeviceStateAccessor.mockLoggedIn(
currentKey: currentKey,
rotationState: .failed(when: .retryInterval, nextKey: nextKey)
)
startDeviceCheck(remoteService: remoteService, deviceStateAccessor: deviceStateAccessor) { result in
let deviceCheck = result.value
XCTAssertNotNil(deviceCheck)
XCTAssertTrue(deviceCheck?.keyRotationStatus.isSucceeded ?? false)
XCTAssertEqual(try? deviceStateAccessor.read().deviceData?.wgKeyData.privateKey, nextKey)
expect.fulfill()
}
waitForExpectations(timeout: 1)
}
func testShouldReportFailedKeyRotataionAttempt() {
let expect = expectation(description: "Wait for operation to complete")
let currentKey = PrivateKey()
let nextKey = PrivateKey()
let remoteService = MockRemoteService(
rotateDeviceKey: { _, _, _ in
throw URLError(.badURL)
}
)
let deviceStateAccessor = MockDeviceStateAccessor.mockLoggedIn(
currentKey: currentKey,
rotationState: .failed(when: .retryInterval, nextKey: nextKey)
)
startDeviceCheck(remoteService: remoteService, deviceStateAccessor: deviceStateAccessor) { result in
let deviceCheck = result.value
XCTAssertNotNil(deviceCheck)
XCTAssertTrue(deviceCheck?.keyRotationStatus.isAttempted ?? false)
XCTAssertEqual(try? deviceStateAccessor.read().deviceData?.wgKeyData.privateKey, currentKey)
expect.fulfill()
}
waitForExpectations(timeout: 1)
}
func testShouldFailOnKeyRotationRace() {
let expect = expectation(description: "Wait for operation to complete")
let currentKey = PrivateKey()
let nextKey = PrivateKey()
let deviceStateAccessor = MockDeviceStateAccessor.mockLoggedIn(
currentKey: currentKey,
rotationState: .failed(when: .retryInterval, nextKey: nextKey)
)
let remoteService = MockRemoteService(
rotateDeviceKey: { _, _, _ in
// Overwrite device state before returning the result from key rotation to simulate the race condition
// in the underlying storage.
try deviceStateAccessor.write(
.loggedIn(
StoredAccountData.mock(),
StoredDeviceData.mock(wgKeyData: StoredWgKeyData(creationDate: Date(), privateKey: currentKey))
)
)
}
)
startDeviceCheck(remoteService: remoteService, deviceStateAccessor: deviceStateAccessor) { result in
let deviceCheck = result.value
XCTAssertNotNil(deviceCheck)
XCTAssertTrue(deviceCheck?.keyRotationStatus.isAttempted ?? false)
XCTAssertEqual(try? deviceStateAccessor.read().deviceData?.wgKeyData.privateKey, currentKey)
expect.fulfill()
}
waitForExpectations(timeout: 1)
}
private func startDeviceCheck(
remoteService: DeviceCheckRemoteServiceProtocol,
deviceStateAccessor: DeviceStateAccessorProtocol,
rotateImmediatelyOnKeyMismatch: Bool = false,
completion: @escaping (Result<DeviceCheck, Error>) -> Void
) {
let operation = DeviceCheckOperation(
dispatchQueue: dispatchQueue,
remoteSevice: remoteService,
deviceStateAccessor: deviceStateAccessor,
rotateImmediatelyOnKeyMismatch: rotateImmediatelyOnKeyMismatch,
completionHandler: completion
)
operationQueue.addOperation(operation)
}
}
/// Mock implementation of a remote service used by `DeviceCheckOperation` to reach the API.
private class MockRemoteService: DeviceCheckRemoteServiceProtocol {
typealias AccountDataHandler = (_ accountNumber: String) throws -> Account
typealias DeviceDataHandler = (_ accountNumber: String, _ deviceIdentifier: String) throws -> Device
typealias RotateDeviceKeyHandler = (
_ accountNumber: String,
_ deviceIdentifier: String,
_ publicKey: PublicKey
) throws -> Void
private let getAccountDataHandler: AccountDataHandler?
private let getDeviceDataHandler: DeviceDataHandler?
private let rotateDeviceKeyHandler: RotateDeviceKeyHandler?
private var currentKey: PublicKey
init(
initialKey: PublicKey = PrivateKey().publicKey,
getAccount: AccountDataHandler? = nil,
getDevice: DeviceDataHandler? = nil,
rotateDeviceKey: RotateDeviceKeyHandler? = nil
) {
currentKey = initialKey
getAccountDataHandler = getAccount
getDeviceDataHandler = getDevice
rotateDeviceKeyHandler = rotateDeviceKey
}
func getAccountData(
accountNumber: String,
completion: @escaping (Result<Account, Error>) -> Void
) -> Cancellable {
DispatchQueue.main.async { [self] in
let result: Result<Account, Error> = Result {
if let getAccountDataHandler {
return try getAccountDataHandler(accountNumber)
} else {
return Account.mock()
}
}
completion(result)
}
return AnyCancellable()
}
func getDevice(
accountNumber: String,
identifier: String,
completion: @escaping (Result<Device, Error>) -> Void
) -> Cancellable {
DispatchQueue.main.async { [self] in
let result: Result<Device, Error> = Result {
if let getDeviceDataHandler {
return try getDeviceDataHandler(accountNumber, identifier)
} else {
return Device.mock(publicKey: currentKey)
}
}
completion(result)
}
return AnyCancellable()
}
func rotateDeviceKey(
accountNumber: String,
identifier: String,
publicKey: PublicKey,
completion: @escaping (Result<Device, Error>) -> Void
) -> Cancellable {
DispatchQueue.main.async { [self] in
let result: Result<Device, Error> = Result {
try rotateDeviceKeyHandler?(accountNumber, identifier, publicKey)
currentKey = publicKey
return Device.mock(publicKey: currentKey)
}
completion(result)
}
return AnyCancellable()
}
}
/// Mock implementation of device state accessor used by `CheckDeviceOperation` to access the storage holding device
/// state.
private class MockDeviceStateAccessor: DeviceStateAccessorProtocol {
private var state: DeviceState
private let stateLock = NSLock()
init(initialState: DeviceState) {
state = initialState
}
func read() throws -> DeviceState {
stateLock.lock()
defer { stateLock.unlock() }
return state
}
func write(_ deviceState: DeviceState) throws {
stateLock.lock()
defer { stateLock.unlock() }
state = deviceState
}
}
/// Time interval since last key rotation used for mocking `StoredWgKeyData`.
private enum TimeSinceLastKeyRotation {
/// No time passed since last key rotation.
case zero
/// Equal to key rotation retry interval.
case retryInterval
/// Equal to key rotation retry interval minus 1 second.
case closeToRetryInterval
/// Equal to cooldown interval used for packet tunnel based rotation.
case packetTunnelCooldownInterval
/// Returns negative time offset that can be used to compute the date in the past that can be used to simulate last
/// attempt date when simulating key rotation.
var timeOffset: TimeInterval {
switch self {
case .zero:
return .zero
case .retryInterval:
return -WgKeyRotation.retryInterval.timeInterval
case .closeToRetryInterval:
return -WgKeyRotation.retryInterval.timeInterval + 1
case .packetTunnelCooldownInterval:
return -WgKeyRotation.packetTunnelCooldownInterval.timeInterval
}
}
}
/// State of last key rotation used for mocking `StoredWgKeyData`.
private enum LastKeyRotationState {
case succeeded
case failed(when: TimeSinceLastKeyRotation, nextKey: PrivateKey)
}
extension MockDeviceStateAccessor {
static func mockLoggedIn(currentKey: PrivateKey, rotationState: LastKeyRotationState) -> MockDeviceStateAccessor {
MockDeviceStateAccessor(initialState: .loggedIn(
StoredAccountData.mock(),
StoredDeviceData.mock(wgKeyData: StoredWgKeyData.mock(currentKey: currentKey, rotationState: rotationState))
))
}
}
private extension StoredWgKeyData {
static func mock(currentKey: PrivateKey, rotationState: LastKeyRotationState) -> StoredWgKeyData {
var keyData = StoredWgKeyData(creationDate: Date(), privateKey: currentKey)
keyData.apply(rotationState)
return keyData
}
private mutating func apply(_ rotationState: LastKeyRotationState) {
switch rotationState {
case .succeeded:
lastRotationAttemptDate = nil
nextPrivateKey = nil
case let .failed(recency, nextKey):
let attemptDate = creationDate.addingTimeInterval(recency.timeOffset)
creationDate = min(creationDate, attemptDate)
lastRotationAttemptDate = attemptDate
nextPrivateKey = nextKey
}
}
}
private extension StoredAccountData {
static func mock() -> StoredAccountData {
StoredAccountData(
identifier: "account-id",
number: "account-number",
expiry: .distantFuture
)
}
}
private extension StoredDeviceData {
static func mock(wgKeyData: StoredWgKeyData) -> StoredDeviceData {
StoredDeviceData(
creationDate: Date(),
identifier: "device-id",
name: "device-name",
hijackDNS: false,
ipv4Address: IPAddressRange(from: "127.0.0.1/32")!,
ipv6Address: IPAddressRange(from: "::ff/64")!,
wgKeyData: wgKeyData
)
}
}
private extension KeyRotationStatus {
/// Returns `true` if key rotation status is `.attempted`.
var isAttempted: Bool {
if case .attempted = self {
return true
}
return false
}
}
private extension AccountVerdict {
/// Returns `true` if account verdict is `.expired`.
var isExpired: Bool {
if case .expired = self {
return true
}
return false
}
// swiftlint:disable:next file_length
}