Revert "Do not deserialize back canonical JSON"

dlon · dlon · commit 06f6b3109fb1 · 2025-03-20T23:03:14.000+01:00
This reverts commit 147a28c.
diff --git a/mullvad-update/src/format/deserializer.rs b/mullvad-update/src/format/deserializer.rs
@@ -106,7 +106,9 @@ pub(super) fn deserialize_and_verify(
 
     Ok(PartialSignedResponse {
         signatures: partial_data.signatures,
-        signed: partial_data.signed,
+        // Serialize back in case something was lost during deserialization
+        signed: serde_json::from_slice(&canon_data)
+            .context("Failed to serialize canonical JSON")?,
     })
 }
 

Original file line number	Diff line number	Diff line change
`@@ -106,7 +106,9 @@ pub(super) fn deserialize_and_verify(`
`106`	`106`
`107`	`107`	`Ok(PartialSignedResponse {`
`108`	`108`	`signatures: partial_data.signatures,`
`109`		`- signed: partial_data.signed,`
	`109`	`+ // Serialize back in case something was lost during deserialization`
	`110`	`+ signed: serde_json::from_slice(&canon_data)`
	`111`	`+ .context("Failed to serialize canonical JSON")?,`
`110`	`112`	`})`
`111`	`113`	`}`
`112`	`114`