Skip to content

Commit 0fb805a

Browse files
committed
Fix formatting and refactor
1 parent e8e302e commit 0fb805a

File tree

15 files changed

+28
-53
lines changed

15 files changed

+28
-53
lines changed

android/lib/map/src/androidTest/java/net/mullvad/mullvadvpn/lib/map/ExampleInstrumentedTest.kt

+3-5
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,11 @@
11
package net.mullvad.mullvadvpn.lib.map
22

3-
import androidx.test.platform.app.InstrumentationRegistry
43
import androidx.test.ext.junit.runners.AndroidJUnit4
5-
4+
import androidx.test.platform.app.InstrumentationRegistry
5+
import org.junit.Assert.*
66
import org.junit.Test
77
import org.junit.runner.RunWith
88

9-
import org.junit.Assert.*
10-
119
/**
1210
* Instrumented test, which will execute on an Android device.
1311
*
@@ -21,4 +19,4 @@ class ExampleInstrumentedTest {
2119
val appContext = InstrumentationRegistry.getInstrumentation().targetContext
2220
assertEquals("net.mullvad.mullvadvpn.lib.map.test", appContext.packageName)
2321
}
24-
}
22+
}

android/lib/map/src/main/kotlin/net/mullvad/mullvadvpn/lib/map/Map.kt

-9
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,21 @@
11
package net.mullvad.mullvadvpn.lib.map
22

33
import android.util.Log
4-
import androidx.compose.animation.core.Animatable
5-
import androidx.compose.animation.core.EaseInOut
6-
import androidx.compose.animation.core.keyframes
7-
import androidx.compose.animation.core.tween
84
import androidx.compose.runtime.Composable
95
import androidx.compose.runtime.DisposableEffect
10-
import androidx.compose.runtime.LaunchedEffect
116
import androidx.compose.runtime.remember
127
import androidx.compose.ui.Modifier
138
import androidx.compose.ui.platform.LocalLifecycleOwner
149
import androidx.compose.ui.viewinterop.AndroidView
1510
import androidx.lifecycle.Lifecycle
1611
import androidx.lifecycle.LifecycleEventObserver
17-
import kotlinx.coroutines.launch
1812
import net.mullvad.mullvadvpn.lib.map.data.CameraPosition
1913
import net.mullvad.mullvadvpn.lib.map.data.MapConfig
2014
import net.mullvad.mullvadvpn.lib.map.data.MapViewState
2115
import net.mullvad.mullvadvpn.lib.map.data.Marker
2216
import net.mullvad.mullvadvpn.lib.map.data.MarkerType
2317
import net.mullvad.mullvadvpn.lib.map.internal.MapGLSurfaceView
2418
import net.mullvad.mullvadvpn.model.LatLng
25-
import net.mullvad.mullvadvpn.model.Latitude
26-
import net.mullvad.mullvadvpn.model.Longitude
2719

2820
@Composable
2921
fun Map(
@@ -42,7 +34,6 @@ fun Map(
4234
Map(modifier = modifier, mapViewState = mapViewState)
4335
}
4436

45-
4637
@Composable
4738
internal fun Map(modifier: Modifier = Modifier, mapViewState: MapViewState) {
4839

android/lib/map/src/main/kotlin/net/mullvad/mullvadvpn/lib/map/data/GlobeColors.kt

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,4 @@ data class GlobeColors(
1111
val landColorArray = landColor.toFloatArray()
1212
val oceanColorArray = oceanColor.toFloatArray()
1313
val contourColorArray = contourColor.toFloatArray()
14-
}
14+
}

android/lib/map/src/main/kotlin/net/mullvad/mullvadvpn/lib/map/data/LocationMarkerColors.kt

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,4 @@ data class LocationMarkerColors(
77
val ringBorderColor: Color = Color.White,
88
val shadowColor: Color = Color.Black.copy(alpha = 0.55f),
99
val perimeterColors: Color = centerColor.copy(alpha = 0.4f)
10-
)
10+
)

android/lib/map/src/main/kotlin/net/mullvad/mullvadvpn/lib/map/data/MapConfig.kt

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,4 @@ data class MapConfig(
1313
LocationMarkerColors(centerColor = Color(0.267f, 0.678f, 0.302f)),
1414
val unsecureMarkerColor: LocationMarkerColors =
1515
LocationMarkerColors(centerColor = Color(0.89f, 0.251f, 0.224f))
16-
)
16+
)

android/lib/map/src/main/kotlin/net/mullvad/mullvadvpn/lib/map/data/MapViewState.kt

+2-9
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,6 @@ package net.mullvad.mullvadvpn.lib.map.data
22

33
import net.mullvad.mullvadvpn.model.LatLng
44

5-
class MapViewState(
6-
val locationMarker: Marker?,
7-
val cameraPosition: CameraPosition
8-
)
5+
class MapViewState(val locationMarker: Marker?, val cameraPosition: CameraPosition)
96

10-
data class CameraPosition(
11-
val latLng: LatLng,
12-
val zoom: Float,
13-
val bias: Float
14-
)
7+
data class CameraPosition(val latLng: LatLng, val zoom: Float, val bias: Float)

android/lib/map/src/main/kotlin/net/mullvad/mullvadvpn/lib/map/internal/GLHelper.kt

+6-2
Original file line numberDiff line numberDiff line change
@@ -92,10 +92,14 @@ internal fun initIndexBuffer(dataBuffer: Buffer): IndexBufferWithLength {
9292
dataBuffer,
9393
GLES20.GL_STATIC_DRAW
9494
)
95-
return IndexBufferWithLength(indexBuffer = buffer[0], length = dataBuffer.capacity() / Float.SIZE_BYTES)
95+
return IndexBufferWithLength(
96+
indexBuffer = buffer[0],
97+
length = dataBuffer.capacity() / Float.SIZE_BYTES
98+
)
9699
}
97100

98-
internal fun newIdentityMatrix(): FloatArray = FloatArray(MATRIX_SIZE).apply { Matrix.setIdentityM(this, 0) }
101+
internal fun newIdentityMatrix(): FloatArray =
102+
FloatArray(MATRIX_SIZE).apply { Matrix.setIdentityM(this, 0) }
99103

100104
internal fun Color.toFloatArray(): FloatArray {
101105
return floatArrayOf(red, green, blue, alpha)
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
package net.mullvad.mullvadvpn.lib.map.internal
22

3-
internal class IndexBufferWithLength(val indexBuffer: Int, val length: Int)
3+
internal class IndexBufferWithLength(val indexBuffer: Int, val length: Int)

android/lib/map/src/main/kotlin/net/mullvad/mullvadvpn/lib/map/internal/MapGLSurfaceView.kt

-1
Original file line numberDiff line numberDiff line change
@@ -27,4 +27,3 @@ internal class MapGLSurfaceView(context: Context, mapConfig: MapConfig) : GLSurf
2727
requestRender()
2828
}
2929
}
30-
Original file line numberDiff line numberDiff line change
@@ -1,14 +1 @@
11
package net.mullvad.mullvadvpn.lib.map.internal
2-
3-
import android.util.Log
4-
import androidx.compose.runtime.Composable
5-
import androidx.compose.runtime.DisposableEffect
6-
import androidx.compose.runtime.remember
7-
import androidx.compose.ui.Modifier
8-
import androidx.compose.ui.platform.LocalLifecycleOwner
9-
import androidx.compose.ui.viewinterop.AndroidView
10-
import androidx.lifecycle.Lifecycle
11-
import androidx.lifecycle.LifecycleEventObserver
12-
import net.mullvad.mullvadvpn.lib.map.data.MapConfig
13-
import net.mullvad.mullvadvpn.lib.map.data.MapViewState
14-

android/lib/map/src/main/kotlin/net/mullvad/mullvadvpn/lib/map/internal/shapes/Globe.kt

+8-4
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,14 @@ package net.mullvad.mullvadvpn.lib.map.internal.shapes
33
import android.content.res.Resources
44
import android.opengl.GLES20
55
import android.opengl.Matrix
6+
import java.nio.ByteBuffer
67
import net.mullvad.mullvadvpn.lib.map.R
78
import net.mullvad.mullvadvpn.lib.map.data.GlobeColors
89
import net.mullvad.mullvadvpn.lib.map.internal.IndexBufferWithLength
910
import net.mullvad.mullvadvpn.lib.map.internal.VERTEX_COMPONENT_SIZE
1011
import net.mullvad.mullvadvpn.lib.map.internal.initArrayBuffer
1112
import net.mullvad.mullvadvpn.lib.map.internal.initIndexBuffer
1213
import net.mullvad.mullvadvpn.lib.map.internal.initShaderProgram
13-
import java.nio.ByteBuffer
1414

1515
class Globe(resources: Resources) {
1616
private val vertexShaderCode =
@@ -42,7 +42,12 @@ class Globe(resources: Resources) {
4242
private val uniformLocation: UniformLocation
4343

4444
private data class AttribLocations(val vertexPosition: Int)
45-
private data class UniformLocation(val color: Int, val projectionMatrix: Int, val modelViewMatrix: Int)
45+
46+
private data class UniformLocation(
47+
val color: Int,
48+
val projectionMatrix: Int,
49+
val modelViewMatrix: Int
50+
)
4651

4752
private val landIndices: IndexBufferWithLength
4853
private val landContour: IndexBufferWithLength
@@ -57,8 +62,7 @@ class Globe(resources: Resources) {
5762
val landVertByteBuffer = ByteBuffer.wrap(landVertByteArray)
5863
landVertexBuffer = initArrayBuffer(landVertByteBuffer)
5964

60-
val landTriangleIndicesStream =
61-
resources.openRawResource(R.raw.land_triangle_indices)
65+
val landTriangleIndicesStream = resources.openRawResource(R.raw.land_triangle_indices)
6266
val landTriangleIndicesByteArray = landTriangleIndicesStream.use { it.readBytes() }
6367
val landTriangleIndicesBuffer = ByteBuffer.wrap(landTriangleIndicesByteArray)
6468
landIndices = initIndexBuffer(landTriangleIndicesBuffer)

android/lib/map/src/main/kotlin/net/mullvad/mullvadvpn/lib/map/internal/shapes/LocationMarker.kt

+3-3
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,16 @@ package net.mullvad.mullvadvpn.lib.map.internal.shapes
33
import android.opengl.GLES20
44
import android.opengl.Matrix
55
import androidx.compose.ui.graphics.Color
6+
import java.nio.FloatBuffer
7+
import kotlin.math.cos
8+
import kotlin.math.sin
69
import net.mullvad.mullvadvpn.lib.map.data.LocationMarkerColors
710
import net.mullvad.mullvadvpn.lib.map.internal.COLOR_COMPONENT_SIZE
811
import net.mullvad.mullvadvpn.lib.map.internal.VERTEX_COMPONENT_SIZE
912
import net.mullvad.mullvadvpn.lib.map.internal.initArrayBuffer
1013
import net.mullvad.mullvadvpn.lib.map.internal.initShaderProgram
1114
import net.mullvad.mullvadvpn.lib.map.internal.toFloatArray
1215
import net.mullvad.mullvadvpn.model.LatLng
13-
import java.nio.FloatBuffer
14-
import kotlin.math.cos
15-
import kotlin.math.sin
1616

1717
internal class LocationMarker(val colors: LocationMarkerColors) {
1818

android/lib/model/src/main/kotlin/net/mullvad/mullvadvpn/model/LatLng.kt

-1
Original file line numberDiff line numberDiff line change
@@ -18,5 +18,4 @@ data class LatLng(val latitude: Latitude, val longitude: Longitude) {
1818
LatLng(latitude - other.latitude, longitude - other.longitude)
1919
}
2020

21-
2221
const val COMPLETE_ANGLE = 360f

android/lib/model/src/main/kotlin/net/mullvad/mullvadvpn/model/Latitude.kt

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,4 +21,4 @@ value class Latitude(val value: Float) {
2121
private const val MAX_LATITUDE_VALUE: Float = COMPLETE_ANGLE / 4 // 90
2222
private val LATITUDE_RANGE = MIN_LATITUDE_VALUE..MAX_LATITUDE_VALUE
2323
}
24-
}
24+
}

android/lib/model/src/main/kotlin/net/mullvad/mullvadvpn/model/Longitude.kt

+1-1
Original file line numberDiff line numberDiff line change
@@ -52,4 +52,4 @@ value class Longitude(val value: Float) {
5252
}
5353
}
5454
}
55-
}
55+
}

0 commit comments

Comments
 (0)