Remove settings only on app uninstall

Author: Jon Petersson

ios/MullvadVPN/AppDelegate.swift

@@ -502,7 +502,11 @@ class AppDelegate: UIResponder, UIApplicationDelegate, UNUserNotificationCenterD
                 }
 
                 SettingsManager.resetStore(completely: true)
+
                 self.accessMethodRepository.reloadWithDefaultsAfterDataRemoval()
+                // At app startup, the relay cache tracker will get populated with a list of overriden IPs.
+                // The overriden IPs will get wiped, therefore, the cache needs to be pruned as well.
+                try? self.relayCacheTracker.refreshCachedRelays()
             }
 
             FirstTimeLaunch.setHasFinished()

ios/MullvadVPN/TunnelManager/SetAccountOperation.swift

@@ -161,8 +161,6 @@ class SetAccountOperation: ResultOperation<StoredAccountData?> {
         completion: @escaping (Result<Void, Error>) -> Void
     ) {
         deleteAccount(accountNumber: accountNumber) { [self] result in
-            interactor.setSettings(LatestTunnelSettings(), persist: true)
-
             if result.isSuccess {
                 interactor.removeLastUsedAccount()
             }
@@ -231,9 +229,6 @@ class SetAccountOperation: ResultOperation<StoredAccountData?> {
             )
         )
 
-        // Reset tunnel settings.
-        interactor.setSettings(LatestTunnelSettings(), persist: true)
-
         // Transition device state to logged in.
         interactor.setDeviceState(.loggedIn(accountData, storedDeviceData), persist: true)
     }

ios/MullvadVPN/TunnelManager/TunnelManager.swift

@@ -1092,8 +1092,6 @@ final class TunnelManager: StorePaymentObserver {
     }
 
     private func unsetTunnelConfiguration(completion: @escaping () -> Void) {
-        setSettings(LatestTunnelSettings(), persist: true)
-
         // Tell the caller to unsubscribe from VPN status notifications.
         prepareForVPNConfigurationDeletion()