Skip to content

Commit 1ccfe63

Browse files
committed
Removed floating action button
1 parent 2423311 commit 1ccfe63

File tree

3 files changed

+12
-19
lines changed

3 files changed

+12
-19
lines changed

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/component/Scaffolding.kt

-5
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import androidx.compose.foundation.lazy.rememberLazyListState
1212
import androidx.compose.foundation.rememberScrollState
1313
import androidx.compose.foundation.verticalScroll
1414
import androidx.compose.material3.ExperimentalMaterial3Api
15-
import androidx.compose.material3.FabPosition
1615
import androidx.compose.material3.Icon
1716
import androidx.compose.material3.MaterialTheme
1817
import androidx.compose.material3.Scaffold
@@ -127,8 +126,6 @@ fun ScaffoldWithMediumTopBar(
127126
lazyListState: LazyListState = rememberLazyListState(),
128127
scrollbarColor: Color = MaterialTheme.colorScheme.onBackground.copy(alpha = AlphaScrollbar),
129128
snackbarHostState: SnackbarHostState = remember { SnackbarHostState() },
130-
floatingActionButton: @Composable () -> Unit = {},
131-
floatingActionButtonPosition: FabPosition = FabPosition.End,
132129
content: @Composable (modifier: Modifier, lazyListState: LazyListState) -> Unit
133130
) {
134131

@@ -146,8 +143,6 @@ fun ScaffoldWithMediumTopBar(
146143
scrollBehavior = scrollBehavior
147144
)
148145
},
149-
floatingActionButton = floatingActionButton,
150-
floatingActionButtonPosition = floatingActionButtonPosition,
151146
snackbarHost = {
152147
SnackbarHost(
153148
snackbarHostState,

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/CustomListsScreen.kt

+11-14
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,11 @@
11
package net.mullvad.mullvadvpn.compose.screen
22

3-
import androidx.compose.foundation.layout.Spacer
43
import androidx.compose.foundation.layout.padding
5-
import androidx.compose.foundation.layout.width
64
import androidx.compose.foundation.lazy.LazyColumn
75
import androidx.compose.foundation.lazy.LazyListScope
86
import androidx.compose.foundation.lazy.LazyListState
9-
import androidx.compose.material.icons.Icons
10-
import androidx.compose.material.icons.filled.Add
11-
import androidx.compose.material3.ExtendedFloatingActionButton
127
import androidx.compose.material3.Icon
8+
import androidx.compose.material3.IconButton
139
import androidx.compose.material3.MaterialTheme
1410
import androidx.compose.material3.SnackbarDuration
1511
import androidx.compose.material3.SnackbarHostState
@@ -20,8 +16,10 @@ import androidx.compose.runtime.remember
2016
import androidx.compose.runtime.rememberCoroutineScope
2117
import androidx.compose.ui.Alignment
2218
import androidx.compose.ui.Modifier
19+
import androidx.compose.ui.graphics.compositeOver
2320
import androidx.compose.ui.platform.LocalContext
2421
import androidx.compose.ui.platform.testTag
22+
import androidx.compose.ui.res.painterResource
2523
import androidx.compose.ui.res.stringResource
2624
import androidx.compose.ui.tooling.preview.Preview
2725
import androidx.lifecycle.compose.collectAsStateWithLifecycle
@@ -47,7 +45,7 @@ import net.mullvad.mullvadvpn.compose.test.NEW_LIST_BUTTON_TEST_TAG
4745
import net.mullvad.mullvadvpn.compose.transitions.SlideInFromRightTransition
4846
import net.mullvad.mullvadvpn.lib.theme.AppTheme
4947
import net.mullvad.mullvadvpn.lib.theme.Dimens
50-
import net.mullvad.mullvadvpn.lib.theme.shape.fabShape
48+
import net.mullvad.mullvadvpn.lib.theme.color.Alpha60
5149
import net.mullvad.mullvadvpn.relaylist.RelayItem
5250
import net.mullvad.mullvadvpn.viewmodel.CustomListsViewModel
5351
import org.koin.androidx.compose.koinViewModel
@@ -124,20 +122,19 @@ fun CustomListsScreen(
124122
ScaffoldWithMediumTopBar(
125123
appBarTitle = stringResource(id = R.string.edit_custom_lists),
126124
navigationIcon = { NavigateBackIconButton(onBackClick) },
127-
floatingActionButton = {
128-
ExtendedFloatingActionButton(
125+
actions = {
126+
IconButton(
129127
onClick = addCustomList,
130-
containerColor = MaterialTheme.colorScheme.primary,
131-
contentColor = MaterialTheme.colorScheme.onPrimary,
132-
shape = MaterialTheme.shapes.fabShape,
133128
modifier = Modifier.testTag(NEW_LIST_BUTTON_TEST_TAG)
134129
) {
135130
Icon(
136-
imageVector = Icons.Filled.Add,
131+
painterResource(id = R.drawable.ic_icons_add),
132+
tint =
133+
MaterialTheme.colorScheme.onBackground
134+
.copy(alpha = Alpha60)
135+
.compositeOver(MaterialTheme.colorScheme.background),
137136
contentDescription = stringResource(id = R.string.new_list)
138137
)
139-
Spacer(modifier = Modifier.width(Dimens.mediumPadding))
140-
Text(stringResource(id = R.string.new_list))
141138
}
142139
},
143140
snackbarHostState = snackbarHostState

android/lib/theme/src/main/kotlin/net/mullvad/mullvadvpn/lib/theme/color/Color.kt

+1
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ const val AlphaDescription = 0.6f
2121
const val AlphaDisconnectButton = 0.6f
2222
const val AlphaChevron = 0.6f
2323
const val AlphaScrollbar = 0.6f
24+
const val Alpha60 = 0.6f
2425
const val AlphaTopBar = 0.8f
2526
const val AlphaInvisible = 0f
2627

0 commit comments

Comments
 (0)