Avoid double negation

Author: niklasberglund

.github/workflows/android-app.yml

@@ -506,7 +506,7 @@ jobs:
           INFRA_FLAVOR: prod
           VALID_TEST_ACCOUNT_NUMBER: ${{ secrets.ANDROID_PROD_TEST_ACCOUNT }}
           INVALID_TEST_ACCOUNT_NUMBER: '0000000000000000'
-          IGNORE_HIGHLY_RATE_LIMITED_TESTS: ${{ github.event_name == 'schedule' && 'false' || 'true' }}
+          ENABLE_HIGHLY_RATE_LIMITED_TESTS: ${{ github.event_name == 'schedule' && 'true' || 'false' }}
           REPORT_DIR: ${{ steps.prepare-report-dir.outputs.report_dir }}
         run: ./android/scripts/run-instrumented-tests.sh
 
@@ -521,7 +521,7 @@ jobs:
         clearPackageData=true,\
         runnerBuilder=de.mannodermaus.junit5.AndroidJUnit5Builder,\
         invalid_test_account_number=0000000000000000,\
-        ignore_highly_rate_limited_tests=${{ github.event_name == 'schedule' && 'false' || 'true' }},\
+        enable_highly_rate_limited_tests=${{ github.event_name == 'schedule' && 'true' || 'false' }},\
         partner_auth=${{ secrets.STAGEMOLE_PARTNER_AUTH }}"
     strategy:
       fail-fast: false

android/scripts/run-instrumented-tests.sh

@@ -16,7 +16,7 @@ TEST_SERVICES_URL=https://dl.google.com/android/maven2/androidx/test/services/te
 PARTNER_AUTH="${PARTNER_AUTH:-}"
 VALID_TEST_ACCOUNT_NUMBER="${VALID_TEST_ACCOUNT_NUMBER:-}"
 INVALID_TEST_ACCOUNT_NUMBER="${INVALID_TEST_ACCOUNT_NUMBER:-}"
-IGNORE_HIGHLY_RATE_LIMITED_TESTS="${IGNORE_HIGHLY_RATE_LIMITED_TESTS:-false}"
+ENABLE_HIGHLY_RATE_LIMITED_TESTS="${ENABLE_HIGHLY_RATE_LIMITED_TESTS:-false}"
 REPORT_DIR="${REPORT_DIR:-}"
 
 while [[ "$#" -gt 0 ]]; do
@@ -131,8 +131,8 @@ case "$TEST_TYPE" in
         echo "Error: The variable PARTNER_AUTH or VALID_TEST_ACCOUNT_NUMBER must be set."
         exit 1
     fi
-    if [[ "${IGNORE_HIGHLY_RATE_LIMITED_TESTS}" == "true" ]]; then
-        OPTIONAL_TEST_ARGUMENTS+=" -e ignore_highly_rate_limited_tests true"
+    if [[ "${ENABLE_HIGHLY_RATE_LIMITED_TESTS}" == "true" ]]; then
+        OPTIONAL_TEST_ARGUMENTS+=" -e enable_highly_rate_limited_tests true"
     fi
     USE_ORCHESTRATOR="true"
     PACKAGE_NAME="net.mullvad.mullvadvpn"

android/test/e2e/build.gradle.kts

@@ -46,7 +46,7 @@ android {
                 put("clearPackageData", "true")
                 addOptionalPropertyAsArgument("valid_test_account_number")
                 addOptionalPropertyAsArgument("invalid_test_account_number")
-                addOptionalPropertyAsArgument("ignore_highly_rate_limited_tests")
+                addOptionalPropertyAsArgument("enable_highly_rate_limited_tests")
             }
     }
 

android/test/e2e/src/main/kotlin/net/mullvad/mullvadvpn/test/e2e/constant/Constants.kt

@@ -4,4 +4,4 @@ const val LOG_TAG = "mullvad-e2e"
 const val PARTNER_AUTH = "partner_auth"
 const val VALID_TEST_ACCOUNT_NUMBER_ARGUMENT_KEY = "valid_test_account_number"
 const val INVALID_TEST_ACCOUNT_NUMBER_ARGUMENT_KEY = "invalid_test_account_number"
-const val IGNORE_HIGHLY_RATE_LIMITED = "ignore_highly_rate_limited_tests"
+const val IGNORE_HIGHLY_RATE_LIMITED = "enable_highly_rate_limited_tests"