Offer to store accout number in password manager

Author: Rawa

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/WelcomeScreen.kt

@@ -29,9 +29,13 @@ import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.text.style.TextOverflow
 import androidx.compose.ui.tooling.preview.Preview
 import androidx.compose.ui.tooling.preview.PreviewParameter
+import androidx.credentials.CreatePasswordRequest
+import androidx.credentials.CredentialManager
+import androidx.credentials.exceptions.CreateCredentialException
 import androidx.lifecycle.Lifecycle
 import androidx.lifecycle.compose.collectAsStateWithLifecycle
 import androidx.lifecycle.compose.dropUnlessResumed
+import co.touchlab.kermit.Logger
 import com.ramcosta.composedestinations.annotation.Destination
 import com.ramcosta.composedestinations.annotation.RootGraph
 import com.ramcosta.composedestinations.generated.NavGraphs
@@ -140,6 +144,17 @@ fun Welcome(
                 snackbarHostState.showSnackbarImmediately(
                     message = context.getString(R.string.error_occurred)
                 )
+            is WelcomeViewModel.UiSideEffect.StoreCredentialsRequest -> {
+                // UserId is not allowed to be empty
+                val createPasswordRequest =
+                    CreatePasswordRequest(id = "-", password = uiSideEffect.accountNumber.value)
+                val credentialsManager = CredentialManager.create(context)
+                try {
+                    credentialsManager.createCredential(context, createPasswordRequest)
+                } catch (e: CreateCredentialException) {
+                    Logger.w("Unable to create Credentials")
+                }
+            }
         }
     }
 

android/app/src/main/kotlin/net/mullvad/mullvadvpn/viewmodel/WelcomeViewModel.kt

@@ -16,6 +16,7 @@ import kotlinx.coroutines.flow.stateIn
 import kotlinx.coroutines.launch
 import net.mullvad.mullvadvpn.compose.state.WelcomeUiState
 import net.mullvad.mullvadvpn.lib.common.util.isAfterNowInstant
+import net.mullvad.mullvadvpn.lib.model.AccountNumber
 import net.mullvad.mullvadvpn.lib.model.WebsiteAuthToken
 import net.mullvad.mullvadvpn.lib.shared.AccountRepository
 import net.mullvad.mullvadvpn.lib.shared.ConnectionProxy
@@ -39,12 +40,18 @@ class WelcomeViewModel(
     val uiState =
         combine(
                 connectionProxy.tunnelState,
-                deviceRepository.deviceState.filterNotNull(),
+                deviceRepository.deviceState.filterNotNull().onEach {
+                    viewModelScope.launch {
+                        it.accountNumber()?.let { accountNumber ->
+                            _uiSideEffect.send(UiSideEffect.StoreCredentialsRequest(accountNumber))
+                        }
+                    }
+                },
                 paymentUseCase.paymentAvailability,
             ) { tunnelState, accountState, paymentAvailability ->
                 WelcomeUiState(
                     tunnelState = tunnelState,
-                    accountNumber = accountState.token(),
+                    accountNumber = accountState.accountNumber(),
                     deviceName = accountState.displayName(),
                     showSitePayment = !isPlayBuild,
                     billingPaymentState = paymentAvailability?.toPaymentState(),
@@ -122,6 +129,8 @@ class WelcomeViewModel(
 
         data object OpenConnectScreen : UiSideEffect
 
+        data class StoreCredentialsRequest(val accountNumber: AccountNumber) : UiSideEffect
+
         data object GenericError : UiSideEffect
     }
 

android/lib/model/src/main/kotlin/net/mullvad/mullvadvpn/lib/model/DeviceState.kt

@@ -15,7 +15,7 @@ sealed class DeviceState : Parcelable {
         return (this as? LoggedIn)?.device?.displayName()
     }
 
-    fun token(): AccountNumber? {
+    fun accountNumber(): AccountNumber? {
         return (this as? LoggedIn)?.accountNumber
     }
 }

android/test/common/src/main/kotlin/net/mullvad/mullvadvpn/test/common/interactor/AppInteractor.kt

@@ -152,4 +152,16 @@ class AppInteractor(
         device.findObjectWithTimeout(By.desc("Remove")).click()
         clickActionButtonByText("Yes, log out device")
     }
+
+    fun dismissStorePasswordPromptIfShown() {
+        try {
+            device.waitForIdle()
+            val selector = By.text("password")
+            device.wait(Until.hasObject(selector), DEFAULT_TIMEOUT)
+            device.findObjectWithTimeout(selector).click()
+            device.pressBack()
+        } catch (e: IllegalArgumentException) {
+            // This is OK since it means the password prompt wasn't shown.
+        }
+    }
 }

android/test/mockapi/src/main/kotlin/net/mullvad/mullvadvpn/test/mockapi/CreateAccountMockApiTest.kt

@@ -24,6 +24,8 @@ class CreateAccountMockApiTest : MockApiTest() {
         app.waitForLoginPrompt()
         app.attemptCreateAccount()
 
+        app.dismissStorePasswordPromptIfShown()
+
         // Assert
         val expectedResult = "1234 1234 1234 1234"
         app.ensureAccountCreated(expectedResult)