Skip to content

Commit 2f9a72f

Browse files
committedJul 23, 2024
Fix false negative in github action
Add a precondition to all os-specific test steps in the desktop end-to-end test github action which checks if there are any vms to test for the given os. . Without this check, the parsing of the vm names assumed that there would exist atleast 1, causing the parsing to fail if there were none. This would show up in the GitHub summary view as a failure, while the intention was for it to be a noop.
1 parent a16537e commit 2f9a72f

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed
 

‎.github/workflows/desktop-e2e.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ jobs:
126126
e2e-test-linux:
127127
name: Linux end-to-end tests
128128
needs: [prepare-matrices, build-linux]
129-
if: '!cancelled()'
129+
if: !cancelled() && (needs.prepare-matrices.outputs.linux_matrix != '[]' && needs.prepare-matrices.outputs.linux_matrix != '')
130130
runs-on: [self-hosted, desktop-test, Linux] # app-test-linux
131131
timeout-minutes: 240
132132
strategy:
@@ -196,7 +196,7 @@ jobs:
196196

197197
e2e-test-windows:
198198
needs: [prepare-matrices, build-windows]
199-
if: '!cancelled()'
199+
if: !cancelled() && (needs.prepare-matrices.outputs.windows_matrix != '[]' && needs.prepare-matrices.outputs.windows_matrix != '')
200200
name: Windows end-to-end tests
201201
runs-on: [self-hosted, desktop-test, Linux] # app-test-linux
202202
timeout-minutes: 240
@@ -263,7 +263,7 @@ jobs:
263263
264264
e2e-test-macos:
265265
needs: [prepare-matrices, build-macos]
266-
if: '!cancelled()'
266+
if: !cancelled() && (needs.prepare-matrices.outputs.macos_matrix != '[]' && needs.prepare-matrices.outputs.macos_matrix != '')
267267
name: macOS end-to-end tests
268268
runs-on: [self-hosted, desktop-test, macOS] # app-test-macos-arm
269269
timeout-minutes: 240

0 commit comments

Comments
 (0)
Failed to load comments.