Skip to content

Commit 32aeeaa

Browse files
committed
Fixes based on feedback
1 parent 4e04ac2 commit 32aeeaa

File tree

3 files changed

+6
-13
lines changed

3 files changed

+6
-13
lines changed

.github/workflows/android-app.yml

+5-9
Original file line numberDiff line numberDiff line change
@@ -157,17 +157,13 @@ jobs:
157157
strategy:
158158
matrix:
159159
include:
160-
- arch: "x86_64"
161-
abi: "x86_64"
160+
- abi: "x86_64"
162161
task-variant: "X86_64"
163-
- arch: "i686"
164-
abi: "x86"
162+
- abi: "x86"
165163
task-variant: "X86"
166-
- arch: "aarch64"
167-
abi: "arm64-v8a"
164+
- abi: "arm64-v8a"
168165
task-variant: "Arm64"
169-
- arch: "armv7"
170-
abi: "armeabi-v7a"
166+
- abi: "armeabi-v7a"
171167
task-variant: "Arm"
172168
steps:
173169
# Fix for HOME path overridden by GH runners when building in containers, see:
@@ -222,7 +218,7 @@ jobs:
222218
- name: Upload native libs
223219
uses: actions/upload-artifact@v4
224220
with:
225-
name: native-libs-${{ matrix.arch }}
221+
name: native-libs-${{ matrix.abi }}
226222
path: android/app/build/rustJniLibs/android
227223
if-no-files-found: error
228224
retention-days: 7

android/app/build.gradle.kts

-3
Original file line numberDiff line numberDiff line change
@@ -296,9 +296,6 @@ tasks.register<Exec>("generateRelayList") {
296296
workingDir = File(repoRootPath)
297297
standardOutput = ByteArrayOutputStream()
298298

299-
// Set this if you get a cargo not found error
300-
// environment =
301-
302299
onlyIf { isReleaseBuild() || !relayListPath.exists() }
303300

304301
commandLine("cargo", "run", "--bin", "relay_list")

wireguard-go-rs/build.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,7 @@ fn android_move_binary(binary: &Path, output: &Path) -> anyhow::Result<()> {
234234

235235
let mut copy_command = Command::new("cp");
236236
// -p command is required to preserve ownership and timestamp of the file to prevent a
237-
// rebuild of this module everytime.
237+
// rebuild of this module every time.
238238
copy_command
239239
.arg("-p")
240240
.arg(binary.to_str().unwrap())

0 commit comments

Comments
 (0)