Skip to content

Commit 38dc4ba

Browse files
Wait for changelog to disappear
1 parent 7c33052 commit 38dc4ba

File tree

3 files changed

+27
-0
lines changed

3 files changed

+27
-0
lines changed

ios/MullvadVPN.xcodeproj/project.pbxproj

+4
Original file line numberDiff line numberDiff line change
@@ -637,6 +637,7 @@
637637
8587A05D2B84D43100152938 /* ChangeLogAlert.swift in Sources */ = {isa = PBXBuildFile; fileRef = 8587A05C2B84D43100152938 /* ChangeLogAlert.swift */; };
638638
8590896C2B61763B003AF5F5 /* LoggedInWithoutTimeUITestCase.swift in Sources */ = {isa = PBXBuildFile; fileRef = 859089682B61763B003AF5F5 /* LoggedInWithoutTimeUITestCase.swift */; };
639639
8590896F2B61763B003AF5F5 /* LoggedOutUITestCase.swift in Sources */ = {isa = PBXBuildFile; fileRef = 8590896B2B61763B003AF5F5 /* LoggedOutUITestCase.swift */; };
640+
85A42B862BB1D627007BABF7 /* XCUIElement+Extensions.swift in Sources */ = {isa = PBXBuildFile; fileRef = 85A42B852BB1D627007BABF7 /* XCUIElement+Extensions.swift */; };
640641
85B267612B849ADB0098E3CD /* mullvad-api.h in Headers */ = {isa = PBXBuildFile; fileRef = 85B267602B849ADB0098E3CD /* mullvad-api.h */; };
641642
85C7A2E92B89024B00035D5A /* SettingsTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 85C7A2E82B89024B00035D5A /* SettingsTests.swift */; };
642643
85D039982BA4711800940E7F /* SettingsMigrationTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 85D039972BA4711800940E7F /* SettingsMigrationTests.swift */; };
@@ -1890,6 +1891,7 @@
18901891
859089692B61763B003AF5F5 /* LoggedInWithTimeUITestCase.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = LoggedInWithTimeUITestCase.swift; sourceTree = "<group>"; };
18911892
8590896A2B61763B003AF5F5 /* BaseUITestCase.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = BaseUITestCase.swift; sourceTree = "<group>"; };
18921893
8590896B2B61763B003AF5F5 /* LoggedOutUITestCase.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = LoggedOutUITestCase.swift; sourceTree = "<group>"; };
1894+
85A42B852BB1D627007BABF7 /* XCUIElement+Extensions.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "XCUIElement+Extensions.swift"; sourceTree = "<group>"; };
18931895
85B267602B849ADB0098E3CD /* mullvad-api.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = "mullvad-api.h"; path = "../../mullvad-api/include/mullvad-api.h"; sourceTree = "<group>"; };
18941896
85C7A2E82B89024B00035D5A /* SettingsTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SettingsTests.swift; sourceTree = "<group>"; };
18951897
85D039972BA4711800940E7F /* SettingsMigrationTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SettingsMigrationTests.swift; sourceTree = "<group>"; };
@@ -3603,6 +3605,7 @@
36033605
850201DA2B503D7700EF8C96 /* RelayTests.swift */,
36043606
8518F6392B601910009EB113 /* Test base classes */,
36053607
85557B152B5ABBBE00795FE1 /* XCUIElementQuery+Extensions.swift */,
3608+
85A42B852BB1D627007BABF7 /* XCUIElement+Extensions.swift */,
36063609
85C7A2E82B89024B00035D5A /* SettingsTests.swift */,
36073610
85D039972BA4711800940E7F /* SettingsMigrationTests.swift */,
36083611
);
@@ -5605,6 +5608,7 @@
56055608
85D039982BA4711800940E7F /* SettingsMigrationTests.swift in Sources */,
56065609
850201DB2B503D7700EF8C96 /* RelayTests.swift in Sources */,
56075610
85139B2D2B84B4A700734217 /* OutOfTimePage.swift in Sources */,
5611+
85A42B862BB1D627007BABF7 /* XCUIElement+Extensions.swift in Sources */,
56085612
852969362B4E9724007EAD4C /* AccessbilityIdentifier.swift in Sources */,
56095613
85E3BDE52B70E18C00FA71FD /* Networking.swift in Sources */,
56105614
85C7A2E92B89024B00035D5A /* SettingsTests.swift in Sources */,

ios/MullvadVPNUITests/Test base classes/BaseUITestCase.swift

+5
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,11 @@ class BaseUITestCase: XCTestCase {
111111
ChangeLogAlert(app)
112112
.tapOkay()
113113
}
114+
115+
// Ensure changelog is no longer shown
116+
_ = app
117+
.otherElements[AccessibilityIdentifier.changeLogAlert.rawValue]
118+
.waitForNonExistence(timeout: Self.shortTimeout)
114119
}
115120

116121
/// Login with specified account number. It is a prerequisite that the login page is currently shown.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
//
2+
// XCUIElement+Extensions.swift
3+
// MullvadVPNUITests
4+
//
5+
// Created by Niklas Berglund on 2024-03-25.
6+
// Copyright © 2024 Mullvad VPN AB. All rights reserved.
7+
//
8+
9+
import XCTest
10+
11+
extension XCUIElement {
12+
func waitForNonExistence(timeout: TimeInterval) -> Bool {
13+
let predicate = NSPredicate(format: "exists == FALSE")
14+
let expectation = XCTNSPredicateExpectation(predicate: predicate, object: self)
15+
_ = XCTWaiter.wait(for: [expectation], timeout: timeout)
16+
return !exists
17+
}
18+
}

0 commit comments

Comments
 (0)