Merge branch 'fix-app-going-into-blocked-state-on-first-time-installs-ios-886'

Author: buggmagnet

ios/CHANGELOG.md

@@ -26,6 +26,9 @@ Line wrap the file at 100 chars.                                              Th
 - Replace the draft key encapsulation mechanism Kyber (round 3) with the standardized
   ML-KEM (FIPS 203) dito in the handshake for Quantum-resistant tunnels.
 
+### Fixed
+- Fix app going into blocked state on first-time installs.
+
 ## [2024.8 - 2024-10-14]
 ### Added
 - Add a new access method that uses the encrypted DNS proxy to reach our API.

ios/MullvadVPN/AppDelegate.swift

@@ -519,15 +519,22 @@ class AppDelegate: UIResponder, UIApplicationDelegate, UNUserNotificationCenterD
         }
     }
 
-    /// Returns an operation that acts on two conditions:
+    /// Returns an operation that acts on the following conditions:
+    /// 1. If the app has never been launched, preload with default settings.
+    /// - or -
     /// 1. Has the app been launched at least once after install? (`FirstTimeLaunch.hasFinished`)
     /// 2. Has the app - at some point in time - been updated from a version compatible with wiping settings?
     /// (`SettingsManager.getShouldWipeSettings()`)
     /// If (1) is `false` and (2) is `true`, we know that the app has been freshly installed/reinstalled and is
     /// compatible, thus triggering a settings wipe.
     private func getWipeSettingsOperation() -> AsyncBlockOperation {
         AsyncBlockOperation {
-            if !FirstTimeLaunch.hasFinished, SettingsManager.getShouldWipeSettings() {
+            let appHasNeverBeenLaunched = !FirstTimeLaunch.hasFinished && !SettingsManager.getShouldWipeSettings()
+            let appWasLaunchedAfterReinstall = !FirstTimeLaunch.hasFinished && SettingsManager.getShouldWipeSettings()
+
+            if appHasNeverBeenLaunched {
+                try? SettingsManager.writeSettings(LatestTunnelSettings())
+            } else if appWasLaunchedAfterReinstall {
                 if let deviceState = try? SettingsManager.readDeviceState(),
                    let accountData = deviceState.accountData,
                    let deviceData = deviceState.deviceData {