Replace TunnelManager setters with updateSettings

Author: acb-mv

ios/MullvadVPN/Coordinators/RelayFilterCoordinator.swift

@@ -58,7 +58,7 @@ class RelayFilterCoordinator: Coordinator, Presentable, RelayCacheTrackerObserve
             var relayConstraints = tunnelManager.settings.relayConstraints
             relayConstraints.filter = .only(filter)
 
-            tunnelManager.setRelayConstraints(relayConstraints)
+            tunnelManager.updateSettings([.relayConstraints(relayConstraints)])
 
             didFinish?(self, filter)
         }

ios/MullvadVPN/Coordinators/SelectLocationCoordinator.swift

@@ -58,7 +58,7 @@ class SelectLocationCoordinator: Coordinator, Presentable, Presenting, RelayCach
             var relayConstraints = tunnelManager.settings.relayConstraints
             relayConstraints.location = .only(relay)
 
-            tunnelManager.setRelayConstraints(relayConstraints) {
+            tunnelManager.updateSettings([.relayConstraints(relayConstraints)]) {
                 self.tunnelManager.startTunnel()
             }
 
@@ -80,7 +80,7 @@ class SelectLocationCoordinator: Coordinator, Presentable, Presenting, RelayCach
             var relayConstraints = tunnelManager.settings.relayConstraints
             relayConstraints.filter = .only(filter)
 
-            tunnelManager.setRelayConstraints(relayConstraints)
+            tunnelManager.updateSettings([.relayConstraints(relayConstraints)])
         }
 
         selectLocationViewController.didFinish = { [weak self] in

ios/MullvadVPN/TunnelManager/TunnelManager.swift

@@ -516,29 +516,6 @@ final class TunnelManager: StorePaymentObserver {
         )
     }
 
-    func setRelayConstraints(
-        _ newConstraints: RelayConstraints,
-        completionHandler: (() -> Void)? = nil
-    ) {
-        scheduleSettingsUpdate(
-            taskName: "Set relay constraints",
-            modificationBlock: { settings in
-                settings.relayConstraints = newConstraints
-            },
-            completionHandler: completionHandler
-        )
-    }
-
-    func setDNSSettings(_ newDNSSettings: DNSSettings, completionHandler: (() -> Void)? = nil) {
-        scheduleSettingsUpdate(
-            taskName: "Set DNS settings",
-            modificationBlock: { settings in
-                settings.dnsSettings = newDNSSettings
-            },
-            completionHandler: completionHandler
-        )
-    }
-
     func refreshRelayCacheTracker() throws {
         try relayCacheTracker.refreshCachedRelays()
     }

ios/MullvadVPN/View controllers/Preferences/CustomDNSViewController.swift

@@ -95,7 +95,7 @@ class CustomDNSViewController: UITableViewController, PreferencesDataSourceDeleg
     // MARK: - PreferencesDataSourceDelegate
 
     func didChangeViewModel(_ viewModel: PreferencesViewModel) {
-        interactor.setDNSSettings(viewModel.asDNSSettings())
+        interactor.updateSettings([.dnsSettings(viewModel.asDNSSettings())])
     }
 
     func showInfo(for item: PreferencesInfoButtonItem) {

ios/MullvadVPN/View controllers/Preferences/PreferencesInteractor.swift

@@ -40,10 +40,6 @@ final class PreferencesInteractor {
         tunnelManager.updateSettings(changes, completionHandler: completion)
     }
 
-    func setDNSSettings(_ newDNSSettings: DNSSettings, completion: (() -> Void)? = nil) {
-        tunnelManager.setDNSSettings(newDNSSettings, completionHandler: completion)
-    }
-
     func setPort(_ port: UInt16?, completion: (() -> Void)? = nil) {
         var relayConstraints = tunnelManager.settings.relayConstraints
 
@@ -53,7 +49,7 @@ final class PreferencesInteractor {
             relayConstraints.port = .any
         }
 
-        tunnelManager.setRelayConstraints(relayConstraints, completionHandler: completion)
+        tunnelManager.updateSettings([.relayConstraints(relayConstraints)], completionHandler: completion)
     }
 }